This is an archive of the discontinued LLVM Phabricator instance.

Differential D95138

[SLC] Baseline test for missed strcpy optimizations in non-zero AS
ClosedPublic

Authored by arichardson on Jan 21 2021, 7:35 AM.

Details

Reviewers
None
Commits
rG81e2550f94ad: [SLC] Baseline test for missed strcpy optimizations in non-zero AS
Summary

This will be fixed in D95142

Diff Detail

Unit TestsFailed

TimeTest
70 msx64 windows > LLVM.ExecutionEngine/JITLink/X86::ELF_ehframe_basic.s

Event Timeline

arichardson created this revision.Jan 21 2021, 7:35 AM
arichardson added a child revision: D95142: [SLC] Simplify strcpy and friends with non-zero address spaces.Jan 21 2021, 8:09 AM
Harbormaster completed remote builds in B86096: Diff 318204.Jan 21 2021, 9:12 AM
arichardson updated this revision to Diff 318834.Jan 24 2021, 5:06 AM

simplify test.
AS0 is already tested in other files so no need to include it here.
This also means we no longer need sed

arichardson retitled this revision from [SLC] Add a baseline test showing missed optimizations for non-zero AS to [SLC] Add a test showing missed strcpy optimizations for non-zero AS.Jan 24 2021, 5:06 AM
arichardson edited the summary of this revision. (Show Details)
arichardson updated this revision to Diff 318835.Jan 24 2021, 5:17 AM
arichardson edited the summary of this revision. (Show Details)

simplify test case (no more need for sed)

Herald added a subscriber: hiraditya. · View Herald TranscriptJan 24 2021, 5:17 AM
Harbormaster completed remote builds in B86455: Diff 318835.Jan 24 2021, 5:18 AM
Harbormaster completed remote builds in B86454: Diff 318834.Jan 24 2021, 5:58 AM
arichardson updated this revision to Diff 318952.Jan 25 2021, 4:15 AM

"fix" failing strncpy_chk-2.ll

Harbormaster completed remote builds in B86529: Diff 318952.Jan 25 2021, 4:16 AM
arichardson updated this revision to Diff 318954.Jan 25 2021, 4:17 AM

update

arichardson published this revision for review.Jan 25 2021, 4:19 AM
arichardson retitled this revision from [SLC] Add a test showing missed strcpy optimizations for non-zero AS to [SLC] Baseline test for missed strcpy optimizations in non-zero AS.
Herald added a project: Restricted Project. · View Herald TranscriptJan 25 2021, 4:19 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B86531: Diff 318954.Jan 25 2021, 4:57 AM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 10 2021, 3:18 AM
This revision was landed with ongoing or failed builds.
Closed by commit rG81e2550f94ad: [SLC] Baseline test for missed strcpy optimizations in non-zero AS (authored by arichardson). · Explain Why
This revision was automatically updated to reflect the committed changes.
arichardson added a commit: rG81e2550f94ad: [SLC] Baseline test for missed strcpy optimizations in non-zero AS.

Revision Contents

PathSize
llvm/
test/
Transforms/
InstCombine/
64 lines

Diff 318954

llvm/test/Transforms/InstCombine/strcpy-nonzero-as.ll

  • This file was added.
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --function-signature --scrub-attributes
; Test that the strcpy library call simplifier also works when the string
; libcall arguments are in a non-zero address space.
; RUN: opt < %s -instcombine -S | FileCheck %s
target datalayout = "e-m:e-p200:128:128:128:64-p:64:64-A200-P200-G200"
@str = private unnamed_addr addrspace(200) constant [17 x i8] c"exactly 16 chars\00", align 1
declare i8 addrspace(200)* @strcpy(i8 addrspace(200)*, i8 addrspace(200)*) addrspace(200)
declare i8 addrspace(200)* @stpcpy(i8 addrspace(200)*, i8 addrspace(200)*) addrspace(200)
declare i8 addrspace(200)* @strncpy(i8 addrspace(200)*, i8 addrspace(200)*, i64) addrspace(200)
declare i8 addrspace(200)* @stpncpy(i8 addrspace(200)*, i8 addrspace(200)*, i64) addrspace(200)
; TODO: this should be converted to a memcpy
define void @test_strcpy_to_memcpy(i8 addrspace(200)* %dst) addrspace(200) nounwind {
; CHECK-LABEL: define {{[^@]+}}@test_strcpy_to_memcpy
; CHECK-SAME: (i8 addrspace(200)* [[DST:%.*]]) addrspace(200) [[ATTR0:#.*]] {
; CHECK-NEXT: entry:
; CHECK-NEXT: [[CALL:%.*]] = call addrspace(200) i8 addrspace(200)* @strcpy(i8 addrspace(200)* [[DST]], i8 addrspace(200)* getelementptr inbounds ([17 x i8], [17 x i8] addrspace(200)* @str, i64 0, i64 0))
; CHECK-NEXT: ret void
;
entry:
%call = call i8 addrspace(200)* @strcpy(i8 addrspace(200)* %dst, i8 addrspace(200)* getelementptr inbounds ([17 x i8], [17 x i8] addrspace(200)* @str, i64 0, i64 0))
ret void
}
; TODO: this should be converted to a memcpy
define void @test_stpcpy_to_memcpy(i8 addrspace(200)* %dst) addrspace(200) nounwind {
; CHECK-LABEL: define {{[^@]+}}@test_stpcpy_to_memcpy
; CHECK-SAME: (i8 addrspace(200)* [[DST:%.*]]) addrspace(200) [[ATTR0]] {
; CHECK-NEXT: entry:
; CHECK-NEXT: [[CALL:%.*]] = call addrspace(200) i8 addrspace(200)* @stpcpy(i8 addrspace(200)* [[DST]], i8 addrspace(200)* getelementptr inbounds ([17 x i8], [17 x i8] addrspace(200)* @str, i64 0, i64 0))
; CHECK-NEXT: ret void
;
entry:
%call = call i8 addrspace(200)* @stpcpy(i8 addrspace(200)* %dst, i8 addrspace(200)* getelementptr inbounds ([17 x i8], [17 x i8] addrspace(200)* @str, i64 0, i64 0))
ret void
}
; TODO: this should be converted to a memcpy
define void @test_strncpy_to_memcpy(i8 addrspace(200)* %dst) addrspace(200) nounwind {
; CHECK-LABEL: define {{[^@]+}}@test_strncpy_to_memcpy
; CHECK-SAME: (i8 addrspace(200)* [[DST:%.*]]) addrspace(200) [[ATTR0]] {
; CHECK-NEXT: entry:
; CHECK-NEXT: [[CALL:%.*]] = call addrspace(200) i8 addrspace(200)* @strncpy(i8 addrspace(200)* [[DST]], i8 addrspace(200)* getelementptr inbounds ([17 x i8], [17 x i8] addrspace(200)* @str, i64 0, i64 0), i64 17)
; CHECK-NEXT: ret void
;
entry:
%call = call i8 addrspace(200)* @strncpy(i8 addrspace(200)* %dst, i8 addrspace(200)* getelementptr inbounds ([17 x i8], [17 x i8] addrspace(200)* @str, i64 0, i64 0), i64 17)
ret void
}
; Note: stpncpy is not handled by SimplifyLibcalls yet, so this should not be changed.
define void @test_stpncpy_to_memcpy(i8 addrspace(200)* %dst) addrspace(200) nounwind {
; CHECK-LABEL: define {{[^@]+}}@test_stpncpy_to_memcpy
; CHECK-SAME: (i8 addrspace(200)* [[DST:%.*]]) addrspace(200) [[ATTR0]] {
; CHECK-NEXT: entry:
; CHECK-NEXT: [[CALL:%.*]] = call addrspace(200) i8 addrspace(200)* @stpncpy(i8 addrspace(200)* [[DST]], i8 addrspace(200)* getelementptr inbounds ([17 x i8], [17 x i8] addrspace(200)* @str, i64 0, i64 0), i64 17)
; CHECK-NEXT: ret void
;
entry:
%call = call i8 addrspace(200)* @stpncpy(i8 addrspace(200)* %dst, i8 addrspace(200)* getelementptr inbounds ([17 x i8], [17 x i8] addrspace(200)* @str, i64 0, i64 0), i64 17)
ret void
}