This is an archive of the discontinued LLVM Phabricator instance.

Differential D95050

Make Value::MaxAlignment(Exponent) constexpr
ClosedPublic

Authored by arichardson on Jan 20 2021, 7:48 AM.

Details

Reviewers
jfb
dexonsmith
Commits
rG581613413c27: Make Value::MaxAlignment(Exponent) constexpr
Summary

This avoids references to the variables be generated when using e.g. max().

Diff Detail

Event Timeline

arichardson created this revision.Jan 20 2021, 7:48 AM
Herald added a subscriber: dexonsmith. · View Herald TranscriptJan 20 2021, 7:48 AM
arichardson requested review of this revision.Jan 20 2021, 7:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 20 2021, 7:48 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B85890: Diff 317876.Jan 20 2021, 9:15 AM
arichardson added a comment.Mar 31 2021, 1:56 AM

ping?

arichardson added a comment.Jul 9 2021, 2:43 AM

ping?

dexonsmith accepted this revision.Jul 9 2021, 10:56 AM

LGTM. Is this worth adding a constexpr unit test for? (I don't see any for the other static constexpr stuff in LLVMCore, so maybe not...)

This revision is now accepted and ready to land.Jul 9 2021, 10:56 AM
Closed by commit rG581613413c27: Make Value::MaxAlignment(Exponent) constexpr (authored by arichardson). · Explain WhyAug 26 2021, 2:10 AM
This revision was automatically updated to reflect the committed changes.
arichardson added a commit: rG581613413c27: Make Value::MaxAlignment(Exponent) constexpr.

Revision Contents

PathSize
llvm/
include/
llvm/
IR/
4 lines

Diff 368835

llvm/include/llvm/IR/Value.h

Show First 20 Lines • Show All 775 Lines • ▼ Show 20 Lines Value *DoPHITranslation(const BasicBlock *CurBB, const BasicBlock *PredBB) {
return const_cast<Value *>( return const_cast<Value *>(
static_cast<const Value *>(this)->DoPHITranslation(CurBB, PredBB)); static_cast<const Value *>(this)->DoPHITranslation(CurBB, PredBB));
} }
/// The maximum alignment for instructions. /// The maximum alignment for instructions.
/// ///
/// This is the greatest alignment value supported by load, store, and alloca /// This is the greatest alignment value supported by load, store, and alloca
/// instructions, and global values. /// instructions, and global values.
static const unsigned MaxAlignmentExponent = 29; static constexpr unsigned MaxAlignmentExponent = 29;
static const unsigned MaximumAlignment = 1u << MaxAlignmentExponent; static constexpr unsigned MaximumAlignment = 1u << MaxAlignmentExponent;
/// Mutate the type of this Value to be of the specified type. /// Mutate the type of this Value to be of the specified type.
/// ///
/// Note that this is an extremely dangerous operation which can create /// Note that this is an extremely dangerous operation which can create
/// completely invalid IR very easily. It is strongly recommended that you /// completely invalid IR very easily. It is strongly recommended that you
/// recreate IR objects with the right types instead of mutating them in /// recreate IR objects with the right types instead of mutating them in
/// place. /// place.
void mutateType(Type *Ty) { void mutateType(Type *Ty) {
▲ Show 20 Lines • Show All 264 Lines • Show Last 20 Lines