Page MenuHomePhabricator

[libc++] Split re.alg tests into locale-dependent and independent tests
ClosedPublic

Authored by arichardson on Jan 19 2021, 6:47 AM.

Details

Summary

Currently all these tests are XFAILED on Linux even though the problem
only seems to be with the few checks that look at collation. To retain
test coverage this splits the locale-dependent tests into a separate
.pass.cpp that is XFAILed as before.
This commit also XFAILs the locale-dependent tests on FreeBSD since the
[=M=] and [.ch.] behaviour for cs_CZ also doesn't seem to match the
behaviour that is expected by these tests.

Diff Detail

Event Timeline

arichardson created this revision.Jan 19 2021, 6:47 AM
arichardson requested review of this revision.Jan 19 2021, 6:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 19 2021, 6:47 AM
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald Transcript
ldionne accepted this revision.Jan 19 2021, 7:17 AM

LGTM once CI passes!

This revision is now accepted and ready to land.Jan 19 2021, 7:17 AM