This is an archive of the discontinued LLVM Phabricator instance.

[docs] Fix overly specific link to uploading patches on Phabricator
ClosedPublic

Authored by ldionne on Jan 18 2021, 12:15 PM.

Details

Summary

The documentation for contributing to LLVM currently links to the section
explaining how to submit a Phabricator review using the web interface.
I believe it would be better to link to the general page for using
Phabricator instead, which explains how to sign up with Phabricator,
and also how to submit patches using either the web interface or the
command-line.

I think this is worth changing because what currently *appears* to be our
preferred way of submitting a patch (through the web interface) isn't
actually what we prefer. Indeed, patches submitted from the command-line
have more meta-data available (such as which repository the patch targets),
and also can't suffer from missing context.

Diff Detail

Event Timeline

ldionne created this revision.Jan 18 2021, 12:15 PM
ldionne requested review of this revision.Jan 18 2021, 12:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 18 2021, 12:15 PM
fhahn accepted this revision.Jan 20 2021, 7:22 AM

That seems indeed better, thanks! LGTM

This revision is now accepted and ready to land.Jan 20 2021, 7:22 AM
ldionne updated this revision to Diff 317886.Jan 20 2021, 8:14 AM

Fix broken link (I generated the documentation to test, this time).

This revision was landed with ongoing or failed builds.Jan 20 2021, 8:14 AM
This revision was automatically updated to reflect the committed changes.