This is an archive of the discontinued LLVM Phabricator instance.

[LoopInfo] Fix a typo in compareLoops
ClosedPublic

Authored by kazu on Jan 18 2021, 11:55 AM.

Reviewers

fhahn
efriedma

Commits

rGfe301f474977: [LoopInfo] Fix a typo in compareLoops

Summary

The code here is checking to see if two sets are identical.
OtherBlocksSet should point to OtherL->getBlocksSet() instead.

kazu requested review of this revision.Jan 18 2021, 11:55 AM

kazu created this revision.

LGTM, thanks!

This revision is now accepted and ready to land.Jan 18 2021, 12:01 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

include/

llvm/

Analysis/

3 lines

Show First 20 Lines • Show All 667 Lines • ▼ Show 20 Lines	static void compareLoops(const LoopT L, const LoopT OtherL,
}		}

std::vector<BlockT *> BBs = L->getBlocks();		std::vector<BlockT *> BBs = L->getBlocks();
std::vector<BlockT *> OtherBBs = OtherL->getBlocks();		std::vector<BlockT *> OtherBBs = OtherL->getBlocks();
assert(compareVectors(BBs, OtherBBs) &&		assert(compareVectors(BBs, OtherBBs) &&
"Mismatched basic blocks in the loops!");		"Mismatched basic blocks in the loops!");

const SmallPtrSetImpl<const BlockT *> &BlocksSet = L->getBlocksSet();		const SmallPtrSetImpl<const BlockT *> &BlocksSet = L->getBlocksSet();
const SmallPtrSetImpl<const BlockT *> &OtherBlocksSet = L->getBlocksSet();		const SmallPtrSetImpl<const BlockT *> &OtherBlocksSet =
		OtherL->getBlocksSet();
assert(BlocksSet.size() == OtherBlocksSet.size() &&		assert(BlocksSet.size() == OtherBlocksSet.size() &&
llvm::all_of(BlocksSet,		llvm::all_of(BlocksSet,
[&OtherBlocksSet](const BlockT *BB) {		[&OtherBlocksSet](const BlockT *BB) {
return OtherBlocksSet.count(BB);		return OtherBlocksSet.count(BB);
}) &&		}) &&
"Mismatched basic blocks in BlocksSets!");		"Mismatched basic blocks in BlocksSets!");
}		}
#endif		#endif
▲ Show 20 Lines • Show All 59 Lines • Show Last 20 Lines