Clang insists that attribute attributes precede __declspec
attributes. This is a longstanding known issue:
https://llvm.org/pr24559. Re-order the visibility and deprecation macros
to fix the build.
Details
Details
- Reviewers
ldionne mstorsjo - Group Reviewers
Restricted Project - Commits
- rG4f24d0dd5386: Fix libc++ clang-cl build, swap attribute order
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
LGTM fwiw, I just looked into the same yesterday, but I guess @ldionne should ack it too.
Comment Actions
LGTM, but we should really fix the clang bug. Please wait for CI to finish before committing.