This is an archive of the discontinued LLVM Phabricator instance.

[clang][cli] NFC: Add PIE parsing for precompiled input and IR
ClosedPublic

Authored by jansvoboda11 on Jan 14 2021, 4:54 AM.

Details

Summary

This patch effectively reverts a small part of D83979.

When we stop parsing LangOpts unconditionally in parseSimpleArgs (above the diff) and move them back to ParseLangArgs (called in else branch) in D94682, LangOpts.PIE would never get parsed in this if branch. This patch ensures this doesn't happen.

Right now, this causes LangOpts.PIE to be parsed twice, but that will be immediately corrected in D94682.

Diff Detail

Event Timeline

jansvoboda11 requested review of this revision.Jan 14 2021, 4:54 AM
jansvoboda11 created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJan 14 2021, 4:54 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
jansvoboda11 edited the summary of this revision. (Show Details)Jan 14 2021, 5:46 AM
jansvoboda11 edited the summary of this revision. (Show Details)Jan 14 2021, 6:14 AM
This revision is now accepted and ready to land.Jan 14 2021, 9:01 AM