This is an archive of the discontinued LLVM Phabricator instance.

Enable YAMLParser tests (They were never enabled and never ran it seems)
ClosedPublic

Authored by arphaman on May 1 2015, 3:20 PM.

Details

Summary

So it seems that the tests for yaml parses that use yaml-bench never actually ran because lit.cfg didn't include
the '.data' file extension that those tests have.

I've attached the patch that re-enables them by adding the '.data' extension to lit.cfg. But maybe it would
be better to rename all the tests in test/YAMLParser so they would use the '.test' file extension?

I've also fixed some tests that were failing for me there.

Diff Detail

Repository
rL LLVM

Event Timeline

arphaman updated this revision to Diff 24836.May 1 2015, 3:20 PM
arphaman retitled this revision from to Enable YAMLParser tests (They were never enabled and never ran it seems).
arphaman updated this object.
arphaman edited the test plan for this revision. (Show Details)
arphaman added reviewers: bogner, bob.wilson, Bigcheese.
arphaman set the repository for this revision to rL LLVM.
arphaman added a subscriber: Unknown Object (MLST).
arphaman updated this revision to Diff 24902.May 4 2015, 12:45 PM
arphaman added a reviewer: dexonsmith.

I've renamed the test files - now they use the 'test' extension instead of the old 'data' extension, so now 'lit.cfg'
doesn't have to be modified.

I've modified yaml-bench so that it would return an error status if an error occurred during parsing.
I've also added the '-use-color' command line option to yaml-bench (To make file check matches error messages in the output stream).

I've also adjusted some tests - got rid of unnecessary XFAILs and used not instead where appropriate. A couple of tests are also passing
when they shouldn't be, the yaml parser is incomplete and has some bugs that will have to be fixed.

The list of files that got modified is:

include/llvm/Support/YAMLParser.h
lib/Support/YAMLParser.cpp
test/YAMLParser/spec-05-02-utf8.test
test/YAMLParser/spec-05-10.test
test/YAMLParser/spec-05-12.test
test/YAMLParser/spec-05-15.test
test/YAMLParser/spec-07-03.test
test/YAMLParser/spec-07-05.test
test/YAMLParser/spec-08-04.test
test/YAMLParser/spec-08-06.test
test/YAMLParser/spec-09-02.test
test/YAMLParser/spec-09-14.test
test/YAMLParser/spec-09-21.test
test/YAMLParser/spec-10-08.test
utils/yaml-bench/YAMLBench.cpp

The other test files just got renamed.

arphaman updated this revision to Diff 24922.May 4 2015, 4:06 PM

I've reformatted the patch and updated the FIXME comments in some of the tests with more descriptive details on why those tests should fail as suggested by Justin.

arphaman updated this revision to Diff 24923.May 4 2015, 4:09 PM
arphaman removed rL LLVM as the repository for this revision.

Added the missing test file changes (I forgot to include the FIXME changes in the previous patch).

This revision was automatically updated to reflect the committed changes.
llvm/trunk/test/YAMLParser/utf8-implicit.test