This is an archive of the discontinued LLVM Phabricator instance.

Differential D94396

Fix macos target assumption in test
ClosedPublic

Authored by thopre on Jan 11 2021, 2:04 AM.

Details

Reviewers
arphaman
hans
jyknight
steven_wu
Commits
rG305ac81e1d4b: Fix macos target assumption in test
Summary

Clang test Driver/macos-apple-silicon-slice-link-libs-darwin-only.cpp
assumes the target is darwin when the host is darwin which is not
necessarily the case, causing the test to fail when it is not. This
commit adds a -triple argument to the clang invocation to ensure the
target is darwin.

Diff Detail

Event Timeline

thopre requested review of this revision.Jan 11 2021, 2:04 AM
thopre created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJan 11 2021, 2:04 AM
Harbormaster completed remote builds in B84646: Diff 315733.Jan 11 2021, 2:57 AM
thopre added reviewers: hans, jyknight, steven_wu.Jan 29 2021, 1:58 AM

Ping?

hans accepted this revision.Jan 29 2021, 2:02 AM
This revision is now accepted and ready to land.Jan 29 2021, 2:02 AM
Closed by commit rG305ac81e1d4b: Fix macos target assumption in test (authored by thopre). · Explain WhyJan 29 2021, 2:22 AM
This revision was automatically updated to reflect the committed changes.
thopre added a commit: rG305ac81e1d4b: Fix macos target assumption in test.

Revision Contents

Diff 320083

clang/test/Driver/macos-apple-silicon-slice-link-libs-darwin-only.cpp

// RUN: %clang -### -arch arm64 -mmacosx-version-min=10.7 %s 2>&1 | FileCheck -check-prefix=ARM64-10_7 %s // RUN: %clang -### -target arm64-apple-darwin -arch arm64 -mmacosx-version-min=10.7 %s 2>&1 | FileCheck -check-prefix=ARM64-10_7 %s
// RUN: %clang -### -arch x86_64 -mmacosx-version-min=10.7 %s 2>&1 | FileCheck -check-prefix=x86_64-10_7 %s // RUN: %clang -### -target x86_64-apple-darwin10 -arch x86_64 -mmacosx-version-min=10.7 %s 2>&1 | FileCheck -check-prefix=x86_64-10_7 %s
// REQUIRES: system-darwin // REQUIRES: system-darwin
// ARM64-10_7-NOT: -lcrt1.10.6.o // ARM64-10_7-NOT: -lcrt1.10.6.o
// x86_64-10_7: -lcrt1.10.6.o // x86_64-10_7: -lcrt1.10.6.o