This is an archive of the discontinued LLVM Phabricator instance.

un-skipped a bunch of tests on Linux
ClosedPublic

Authored by vharron on Apr 30 2015, 10:56 PM.

Details

Summary

Some have been marked as skipIfLinux for years.
The seem to be passing so I've enabled them.

Diff Detail

Repository
rL LLVM

Event Timeline

vharron updated this revision to Diff 24793.Apr 30 2015, 10:56 PM
vharron retitled this revision from to un-skipped a bunch of tests on Linux.
vharron updated this object.
vharron edited the test plan for this revision. (Show Details)
vharron added reviewers: clayborg, ovyalov, labath.
labath accepted this revision.May 1 2015, 3:44 AM
labath edited edge metadata.

LGTM, the more tests, the merrier. :)

This revision is now accepted and ready to land.May 1 2015, 3:44 AM
ovyalov accepted this revision.May 1 2015, 6:16 AM
ovyalov edited edge metadata.

Looks good.

clayborg accepted this revision.May 1 2015, 9:36 AM
clayborg edited edge metadata.

Looks good.

This revision was automatically updated to reflect the committed changes.
flackr added a subscriber: flackr.May 8 2015, 11:07 AM
flackr added inline comments.
lldb/trunk/test/lang/c/modules/TestCModules.py
36

This test is basically a no-op if not darwin (only tests initialization - setting and hitting a breakpoint), except that for mac->linux platform.system() is "Darwin" (and the test fails). Should we keep it skipped? Check the target platform as well as the host platform?