Page MenuHomePhabricator

flackr (Robert Flack)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 20 2015, 10:23 AM (254 w, 5 d)

Recent Activity

May 26 2015

flackr committed rL238274: Implement and use adb push for PlatformAndroid::PutFile.
Implement and use adb push for PlatformAndroid::PutFile
May 26 2015, 7:23 PM
flackr closed D9943: Implement and use adb push for PlatformAndroid::PutFile by committing rL238274: Implement and use adb push for PlatformAndroid::PutFile.
May 26 2015, 7:23 PM
flackr added inline comments to D9943: Implement and use adb push for PlatformAndroid::PutFile.
May 26 2015, 7:19 PM
flackr updated the diff for D9943: Implement and use adb push for PlatformAndroid::PutFile.
  • Comment constant
  • Use nullptr
May 26 2015, 7:19 PM
flackr added inline comments to D9943: Implement and use adb push for PlatformAndroid::PutFile.
May 26 2015, 9:53 AM
flackr updated the diff for D9943: Implement and use adb push for PlatformAndroid::PutFile.
  • Get modification time for adb push from source file (Pass FileSpec directly through)
  • Hard-code file mode flags (to not rely on platform definitions)
  • Return failure if a failure occurs reading the source file.
May 26 2015, 9:52 AM

May 22 2015

flackr retitled D9943: Implement and use adb push for PlatformAndroid::PutFile from to Implement and use adb push for PlatformAndroid::PutFile.
May 22 2015, 11:48 AM

May 21 2015

flackr committed rL237907: Only check for matching arch and UUID when looking for dsym in vincinity of….
Only check for matching arch and UUID when looking for dsym in vincinity of…
May 21 2015, 8:48 AM
flackr closed D9896: Only check for matching arch and UUID when looking for dsym in vincinity of executable. by committing rL237907: Only check for matching arch and UUID when looking for dsym in vincinity of….
May 21 2015, 8:48 AM

May 20 2015

flackr updated the diff for D9896: Only check for matching arch and UUID when looking for dsym in vincinity of executable..

Make static and use function indentation conventions.

May 20 2015, 2:30 PM
flackr retitled D9896: Only check for matching arch and UUID when looking for dsym in vincinity of executable. from to Only check for matching arch and UUID when looking for dsym in vincinity of executable..
May 20 2015, 2:17 PM
flackr accepted D9890: Default dst value for platform put-file..

LGTM

May 20 2015, 1:00 PM

May 15 2015

flackr committed rL237467: Only check _ZN function prefix in Linux and FreeBSD targets in SymbolFileDWARF.
Only check _ZN function prefix in Linux and FreeBSD targets in SymbolFileDWARF
May 15 2015, 12:03 PM
flackr closed D9782: Only check for _ZN function prefix in Linux and FreeBSD targets in SymbolFileDWARF by committing rL237467: Only check _ZN function prefix in Linux and FreeBSD targets in SymbolFileDWARF.
May 15 2015, 12:03 PM
flackr committed rL237466: Choose stdlib for test suite based on target platform..
Choose stdlib for test suite based on target platform.
May 15 2015, 11:58 AM
flackr closed D9797: Choose stdlib for test suite based on target platform. by committing rL237466: Choose stdlib for test suite based on target platform..
May 15 2015, 11:58 AM
flackr added a comment to D9797: Choose stdlib for test suite based on target platform..

And done in one more location that slipped by before :-).

May 15 2015, 11:38 AM
flackr updated the diff for D9797: Choose stdlib for test suite based on target platform..

Use platformIsDarwin instead of manually checking if the platform is in darwin triples.

May 15 2015, 11:37 AM
flackr retitled D9797: Choose stdlib for test suite based on target platform. from to Choose stdlib for test suite based on target platform..
May 15 2015, 10:45 AM
flackr committed rL237446: Add EmulateInstructionMIPS to the xcode project file to fix build after r237420..
Add EmulateInstructionMIPS to the xcode project file to fix build after r237420.
May 15 2015, 6:41 AM
flackr committed rL237444: Skip TestPluginCommands.py if host lldb library is incompatible with remote..
Skip TestPluginCommands.py if host lldb library is incompatible with remote.
May 15 2015, 5:43 AM
flackr closed D9770: Skip TestPluginCommands.py if host lldb library is incompatible with remote. by committing rL237444: Skip TestPluginCommands.py if host lldb library is incompatible with remote..
May 15 2015, 5:43 AM

May 14 2015

flackr added a comment to D9782: Only check for _ZN function prefix in Linux and FreeBSD targets in SymbolFileDWARF.

zturner, I added a comment about Windows like you suggested.

May 14 2015, 7:02 PM
flackr updated the diff for D9782: Only check for _ZN function prefix in Linux and FreeBSD targets in SymbolFileDWARF.
  • Check for hexagon machine.
  • Added comment to fix object arch on Windows and detect global / anonymous namespace symbols there.
May 14 2015, 7:00 PM
flackr added inline comments to D9770: Skip TestPluginCommands.py if host lldb library is incompatible with remote..
May 14 2015, 6:47 PM
flackr updated the diff for D9770: Skip TestPluginCommands.py if host lldb library is incompatible with remote..

Check for compatible architecture as well as platform.

May 14 2015, 6:47 PM
flackr added inline comments to D9754: Enable workaround for finding functions in global namespace on linux binaries on all hosts..
May 14 2015, 2:05 PM
flackr retitled D9782: Only check for _ZN function prefix in Linux and FreeBSD targets in SymbolFileDWARF from to Only check for _ZN function prefix in Linux and FreeBSD targets in SymbolFileDWARF.
May 14 2015, 2:03 PM
flackr updated the diff for D9770: Skip TestPluginCommands.py if host lldb library is incompatible with remote..

Use + to concatenate the platform lists.

May 14 2015, 7:22 AM
flackr retitled D9770: Skip TestPluginCommands.py if host lldb library is incompatible with remote. from to Skip TestPluginCommands.py if host lldb library is incompatible with remote..
May 14 2015, 7:20 AM

May 13 2015

flackr committed rL237288: Select expected remote libc++ library name based on remote platform..
Select expected remote libc++ library name based on remote platform.
May 13 2015, 1:21 PM
flackr closed D9759: Select expected remote libc++ library name based on remote platform. by committing rL237288: Select expected remote libc++ library name based on remote platform..
May 13 2015, 1:21 PM
flackr retitled D9759: Select expected remote libc++ library name based on remote platform. from to Select expected remote libc++ library name based on remote platform..
May 13 2015, 12:00 PM
flackr committed rL237271: Check the host platform to determine logging channel to test in TestRegisters.py.
Check the host platform to determine logging channel to test in TestRegisters.py
May 13 2015, 11:26 AM
flackr closed D9755: Check the host platform to determine logging channel to test in TestRegisters.py by committing rL237271: Check the host platform to determine logging channel to test in TestRegisters.py.
May 13 2015, 11:26 AM
flackr committed rL237270: Enable workaround for finding functions in global namespace on linux binaries on.
Enable workaround for finding functions in global namespace on linux binaries on
May 13 2015, 11:23 AM
flackr closed D9754: Enable workaround for finding functions in global namespace on linux binaries on all hosts. by committing rL237270: Enable workaround for finding functions in global namespace on linux binaries on.
May 13 2015, 11:23 AM
flackr retitled D9755: Check the host platform to determine logging channel to test in TestRegisters.py from to Check the host platform to determine logging channel to test in TestRegisters.py.
May 13 2015, 11:05 AM
flackr retitled D9754: Enable workaround for finding functions in global namespace on linux binaries on all hosts. from to Enable workaround for finding functions in global namespace on linux binaries on all hosts..
May 13 2015, 10:49 AM

May 12 2015

flackr committed rL237221: Don't change the selected platform when creating the dummy target..
Don't change the selected platform when creating the dummy target.
May 12 2015, 5:43 PM
flackr closed D9712: Don't change the selected platform when creating the dummy target. by committing rL237221: Don't change the selected platform when creating the dummy target..
May 12 2015, 5:43 PM
flackr retitled D9712: Don't change the selected platform when creating the dummy target. from to Don't change the selected platform when creating the dummy target..
May 12 2015, 11:56 AM
flackr committed rL237128: Call remote platform GetSupportedArchitectureAtIndex if connected to remote..
Call remote platform GetSupportedArchitectureAtIndex if connected to remote.
May 12 2015, 6:26 AM
flackr closed D9672: Call remote platform GetSupportedArchAtIndex if connected to remote. by committing rL237128: Call remote platform GetSupportedArchitectureAtIndex if connected to remote..
May 12 2015, 6:26 AM
flackr added a comment to D9672: Call remote platform GetSupportedArchAtIndex if connected to remote..

The concept looks good, but when PlatformLinux is the host and it runs on a non Linux OS then I think it shouldn't return any supported architecture. It was always broken but it would be a good point to address it as you change the full GetSupportedArchitectureAtIndex code.

May 12 2015, 5:31 AM
flackr updated the diff for D9672: Call remote platform GetSupportedArchAtIndex if connected to remote..

Removed class and restored to comparison to index, and ensured that the returned arch is linux, otherwise return no supported archs.

May 12 2015, 5:29 AM

May 11 2015

flackr added a comment to D9683: Change Linux Platform to support non-host Linux architectures.

Repeating my comment in what seems to be the active patch. Do we need to enumerate all of the architectures? I put up http://reviews.llvm.org/D9672 earlier today to get non x86 working again where it queries the remote PlatformGdbServer if not the host. WDTY?

May 11 2015, 5:20 PM
flackr added reviewers for D9672: Call remote platform GetSupportedArchAtIndex if connected to remote.: clayborg, ted.
May 11 2015, 3:51 PM
flackr added a comment to D8709: Change Linux Platform to support non-host Linux architectures.

Hey, do we need to enumerate all of the architectures? I put up http://reviews.llvm.org/D9672 to get non x86 working again where it queries the remote PlatformGdbServer if not the host. WDTY?

May 11 2015, 3:50 PM
flackr added a comment to rL236933: Convert mmap options for target in InferiorCallMmap..

Thanks for your help diagnosing this, I've put up http://reviews.llvm.org/D9672 to hopefully fix the supported architecture issues.

May 11 2015, 11:54 AM
flackr retitled D9672: Call remote platform GetSupportedArchAtIndex if connected to remote. from to Call remote platform GetSupportedArchAtIndex if connected to remote..
May 11 2015, 11:53 AM

May 9 2015

flackr committed rL236933: Convert mmap options for target in InferiorCallMmap..
Convert mmap options for target in InferiorCallMmap.
May 9 2015, 8:57 AM
flackr closed D9511: Convert mmap options for target in InferiorCallMmap. by committing rL236933: Convert mmap options for target in InferiorCallMmap..
May 9 2015, 8:57 AM

May 8 2015

flackr accepted D9615: TestCModules was effectively skipped on Linux.

lgtm, thanks

May 8 2015, 11:56 AM
flackr added inline comments to D9428: un-skipped a bunch of tests on Linux.
May 8 2015, 11:07 AM

May 7 2015

flackr requested review of D9511: Convert mmap options for target in InferiorCallMmap..

Looking up the mmap function address from the symbol table seems to have started working - we should still load debug symbols when possible but that can be done in a separate change.

This change is pretty much the minimal required to get this working. The process is a ProcessGDBRemote, and the platform is a PlatformRemoteGDBServer so I think we still need to check the target architecture if we try to move this to the process / platform.

If you do a "platform select remote-linux", the platform is (or should be) PlatformLinux, which contains a PlatformRemoteGDBServer as a member and then proxies all the operations to it, if it does not want special handling. E.g., PlatformLinux::GetProcessInfo is implemented like

if (IsHost())
{
    success = Platform::GetProcessInfo (pid, process_info);
}
else
{
    if (m_remote_platform_sp)
        success = m_remote_platform_sp->GetProcessInfo (pid, process_info); // This is a PlatformRemoteGDBServer
}

So I think you should be able to thread your handling through the platform.

May 7 2015, 8:57 PM
flackr updated the diff for D9511: Convert mmap options for target in InferiorCallMmap..
  • Delegate to Platform to convert Mmap flags.
  • Fix platform when running remote-linux from mac by hard-coding linux archs, previously used host binary arch spec (e.g. macosx when running from mac)
May 7 2015, 8:53 PM

May 5 2015

flackr added a comment to D9511: Convert mmap options for target in InferiorCallMmap..

Looking up the mmap function address from the symbol table seems to have started working - we should still load debug symbols when possible but that can be done in a separate change.

May 5 2015, 6:12 PM
flackr retitled D9511: Convert mmap options for target in InferiorCallMmap. from to Convert mmap options for target in InferiorCallMmap..
May 5 2015, 6:00 PM

May 1 2015

flackr accepted D9427: Fixed skipIfLinuxClang to check the target architecture, not the host architecture.

As a sidenote, I wonder how many of these skip if linux checks should also be skipping if freebsd.

May 1 2015, 7:49 AM

Apr 27 2015

flackr added a comment to D9177: Add CMAKE_EXECUTABLE_SUFFIX to build with Android toolchain on Windows..

I'm a little confused about why you're setting EXECUTABLE_SUFFIX in Android.cmake but checking CMAKE_EXECUTABLE_SUFFIX in Makefile.rules, shouldn't those both be CMAKE_EXECUTABLE_SUFFIX?

Apr 27 2015, 7:43 AM
flackr added a comment to D9177: Add CMAKE_EXECUTABLE_SUFFIX to build with Android toolchain on Windows..

I'm a little confused about why you're setting EXECUTABLE_SUFFIX in Android.cmake but checking CMAKE_EXECUTABLE_SUFFIX in Makefile.rules, shouldn't those both be CMAKE_EXECUTABLE_SUFFIX?

Apr 27 2015, 7:38 AM

Apr 24 2015

flackr committed rL235737: Look for both .debug and dsym debugging symbol information for stripped….
Look for both .debug and dsym debugging symbol information for stripped…
Apr 24 2015, 11:13 AM
flackr closed D9174: Look for both .debug and dsym debugging symbol information for stripped executable. by committing rL235737: Look for both .debug and dsym debugging symbol information for stripped….
Apr 24 2015, 11:13 AM
flackr updated the diff for D9174: Look for both .debug and dsym debugging symbol information for stripped executable..

The lovely test suite caught a couple errors which I've addressed in this patch

  • NULL is acceptable input for arch or uuid to Symbols::FindSymbolFileInBundle to ignore that attribute.
  • Properly check for dsym symbols even if there's no symbol filename in the module spec.
Apr 24 2015, 10:17 AM

Apr 23 2015

flackr added a comment to D9174: Look for both .debug and dsym debugging symbol information for stripped executable..

Greg, please check if I'm checking the module spec correctly. I'm not sure if I should only be looking for matching UUID and arch whereas the ModuleSpecList::FindMatchingModuleSpec seems like it will check the FileSpec and PlatformFileSpec as well. It passes the stripped symbols test though which I presume is testing it.

Apr 23 2015, 1:01 PM
flackr updated the diff for D9174: Look for both .debug and dsym debugging symbol information for stripped executable..

Use ObjectFile::GetModuleSpecifications to check for matching module spec.

Apr 23 2015, 12:53 PM
flackr added a comment to D9177: Add CMAKE_EXECUTABLE_SUFFIX to build with Android toolchain on Windows..

I think we need to do the same in test/make/Makefile.rules for AR and OBJCOPY.

Apr 23 2015, 6:47 AM

Apr 22 2015

flackr added inline comments to D9174: Look for both .debug and dsym debugging symbol information for stripped executable..
Apr 22 2015, 5:40 AM

Apr 21 2015

flackr added a comment to D9174: Look for both .debug and dsym debugging symbol information for stripped executable..

I wanted to float this patch by you to get an early impression. Previously we only looked for dsym debugging info on mac and only .debug on linux. This patch should allow us to locate either. What I've tried to do is move as much of the symbol location into common/Symbols.cpp that I can. What do you think of this direction?

Apr 21 2015, 2:55 PM
flackr retitled D9174: Look for both .debug and dsym debugging symbol information for stripped executable. from to Look for both .debug and dsym debugging symbol information for stripped executable..
Apr 21 2015, 2:49 PM

Apr 20 2015

flackr committed rL235320: Allow specifying tool path/prefix for tests with CROSS_COMPILE..
Allow specifying tool path/prefix for tests with CROSS_COMPILE.
Apr 20 2015, 11:11 AM
flackr closed D9072: Allow specifying tool path/prefix for tests with CROSS_COMPILE. by committing rL235320: Allow specifying tool path/prefix for tests with CROSS_COMPILE..
Apr 20 2015, 11:11 AM

Apr 17 2015

flackr updated the diff for D9072: Allow specifying tool path/prefix for tests with CROSS_COMPILE..

Use consistent immediate expansion of CROSS_COMPILE in AR and OBJCOPY.

Apr 17 2015, 3:08 AM
flackr retitled D9072: Allow specifying tool path/prefix for tests with CROSS_COMPILE. from to Allow specifying tool path/prefix for tests with CROSS_COMPILE..
Apr 17 2015, 3:01 AM
flackr committed rL235164: Uses the target platform to determine the platform context..
Uses the target platform to determine the platform context.
Apr 17 2015, 1:05 AM
flackr closed D9047: Uses the target platform to determine the platform context. by committing rL235164: Uses the target platform to determine the platform context..
Apr 17 2015, 1:05 AM

Apr 16 2015

flackr accepted D9052: Pass Process* along with ObjectFile::GetModuleSpecifications to allow fall back to process's architecture if OS is unknown. .

LGTM, this gets at least 3 more tests passing when running maxosx -> linux, woohoo!
TestCPPExceptionBreakpoint.py
TestCPPExceptionBreakpoints.py
TestGlobalVariables.py

Apr 16 2015, 10:18 AM
flackr added inline comments to D9047: Uses the target platform to determine the platform context..
Apr 16 2015, 7:58 AM
flackr updated the diff for D9047: Uses the target platform to determine the platform context..

Remove platformIsLinux rather than start creating platformIsX for each platform string getPlatform can return.

Apr 16 2015, 7:57 AM
flackr committed rL235083: Append to CFLAGS_EXTRAS and LD_EXTRAS when building cmdline..
Append to CFLAGS_EXTRAS and LD_EXTRAS when building cmdline.
Apr 16 2015, 2:21 AM
flackr closed D8942: Append to CFLAGS_EXTRAS and LD_EXTRAS when building cmdline. by committing rL235083: Append to CFLAGS_EXTRAS and LD_EXTRAS when building cmdline..
Apr 16 2015, 2:21 AM
flackr updated the test plan for D9047: Uses the target platform to determine the platform context..
Apr 16 2015, 2:03 AM
flackr retitled D9047: Uses the target platform to determine the platform context. from to Uses the target platform to determine the platform context..
Apr 16 2015, 2:01 AM

Apr 15 2015

flackr added inline comments to D8942: Append to CFLAGS_EXTRAS and LD_EXTRAS when building cmdline..
Apr 15 2015, 2:31 AM
flackr updated the diff for D8942: Append to CFLAGS_EXTRAS and LD_EXTRAS when building cmdline..

Revert first attempt to escape environment variables - need more platform specific investigation.

Apr 15 2015, 2:31 AM

Apr 13 2015

flackr added a comment to rL234514: Fix @skipUnlessPlatform and @skipIfPlatform decorators to work on classes..

I'll try to track down which commit(s) broke the tests by applying this patch to earlier revisions.

Apr 13 2015, 1:06 AM

Apr 10 2015

flackr added a comment to rL234514: Fix @skipUnlessPlatform and @skipIfPlatform decorators to work on classes..

This patch effectively re-enabled all of the following tests on darwin:
TestAddDsymCommand.py TestAddDsymMidExecutionCommand.py TestConstStrings.py TestFoundationDisassembly.py TestObjCBreakpoints.py TestObjCDynamicSBType.py TestObjCMethodReturningBOOL.py TestObjCMethods2.py TestObjCMethods.py TestObjcOptimized.py TestPrintObj.py TestRdar10967107.py TestRdar11355592.py TestRdar12408181.py TestRuntimeTypes.py TestSetData.py TestSymbolTable.py

Apr 10 2015, 10:31 AM
flackr updated the diff for D8942: Append to CFLAGS_EXTRAS and LD_EXTRAS when building cmdline..

Escape quotes and backslashes in environment variable assignments.

Apr 10 2015, 7:58 AM

Apr 9 2015

flackr added inline comments to D8942: Append to CFLAGS_EXTRAS and LD_EXTRAS when building cmdline..
Apr 9 2015, 5:12 PM
flackr retitled D8942: Append to CFLAGS_EXTRAS and LD_EXTRAS when building cmdline. from to Append to CFLAGS_EXTRAS and LD_EXTRAS when building cmdline..
Apr 9 2015, 5:10 PM
flackr committed rL234514: Fix @skipUnlessPlatform and @skipIfPlatform decorators to work on classes..
Fix @skipUnlessPlatform and @skipIfPlatform decorators to work on classes.
Apr 9 2015, 11:11 AM
flackr closed D8903: Fix @skipUnlessPlatform and @skipIfPlatform decorators to work on entire test classes as well. by committing rL234514: Fix @skipUnlessPlatform and @skipIfPlatform decorators to work on classes..
Apr 9 2015, 11:11 AM
flackr added a comment to D8856: [LLDB][MIPS] Add LinuxSignals for mips64 and change trap opcode for mips64el. .

This seems to have broken the xcode build for me - confirmed that reverting fixes the build failure:

Apr 9 2015, 9:04 AM
flackr committed rL234492: Fix expectedFailureLLGS to expect failure when host platform is not linux..
Fix expectedFailureLLGS to expect failure when host platform is not linux.
Apr 9 2015, 7:57 AM
flackr closed D8869: Fix expectedFailureLLGS to expect failure when host platform is not linux. by committing rL234492: Fix expectedFailureLLGS to expect failure when host platform is not linux..
Apr 9 2015, 7:57 AM

Apr 8 2015

flackr added a reviewer for D8903: Fix @skipUnlessPlatform and @skipIfPlatform decorators to work on entire test classes as well.: clayborg.
Apr 8 2015, 1:57 PM
flackr added a comment to rL233547: Replace sys.platform skips in tests with @skip decorators which check against….

Looks like the skipUnlessPlatform decorator works with individual test cases, but not entire classes. I believe I have a fix in http://reviews.llvm.org/D8903.

Apr 8 2015, 12:21 PM
flackr retitled D8903: Fix @skipUnlessPlatform and @skipIfPlatform decorators to work on entire test classes as well. from to Fix @skipUnlessPlatform and @skipIfPlatform decorators to work on entire test classes as well..
Apr 8 2015, 12:19 PM

Apr 7 2015

flackr retitled D8869: Fix expectedFailureLLGS to expect failure when host platform is not linux. from to Fix expectedFailureLLGS to expect failure when host platform is not linux..
Apr 7 2015, 7:41 AM