Page MenuHomePhabricator

[NFC] Don't copy MachineFrameInfo on each invocation of HasAlias
ClosedPublic

Authored by sanjoy.google on Jan 6 2021, 9:50 AM.

Details

Summary

Also fix a typo in a comment. This fixes a compile time issue in XLA
(https://www.tensorflow.org/xla).

Diff Detail

Event Timeline

sanjoy.google created this revision.Jan 6 2021, 9:50 AM
sanjoy.google requested review of this revision.Jan 6 2021, 9:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 6 2021, 9:50 AM

Actually make sure this builds. :)

rnk accepted this revision.Jan 6 2021, 10:00 AM
rnk added a subscriber: hliao.

lgtm

llvm/lib/CodeGen/MachineInstr.cpp
1290

@hliao, this value capture is the source of the issue.

This revision is now accepted and ready to land.Jan 6 2021, 10:00 AM
This revision was landed with ongoing or failed builds.Jan 6 2021, 7:15 PM
This revision was automatically updated to reflect the committed changes.