This is an archive of the discontinued LLVM Phabricator instance.

[sanitizer][Darwin] Suppress -Wno-non-virtual-dtor warning
ClosedPublic

Authored by yln on Jan 5 2021, 4:16 PM.

Details

Summary

Suppress the warning:

'fake_shared_weak_count' has virtual functions but non-virtual destructor [-Wnon-virtual-dtor]

The warning has been recently enabled [1], but the associated cleanup
missed this instance in Darwin code [2].

[1] 9c31e12609e1935eb84a2497ac08a49e3139859a
[2] d48f2d7c02743571075bb7812bb4c9e634e51ed1

Diff Detail

Event Timeline

yln requested review of this revision.Jan 5 2021, 4:16 PM
yln created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJan 5 2021, 4:16 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
kubamracek accepted this revision.Jan 5 2021, 4:17 PM
This revision is now accepted and ready to land.Jan 5 2021, 4:17 PM
This revision was automatically updated to reflect the committed changes.