This is an archive of the discontinued LLVM Phabricator instance.

Differential D94120

[mlir] Print the correct tool name in mlirTranslateMain
ClosedPublic

Authored by youngar on Jan 5 2021, 1:54 PM.

Details

Reviewers
mehdi_amini
Commits
rG91f17ba24e86: [mlir] Print the correct tool name in mlirTranslateMain
Summary
The passed in tool name is not used, causing the wrong tool name to be printed by the help text.

Diff Detail

Event Timeline

youngar created this revision.Jan 5 2021, 1:54 PM
Herald added subscribers: teijeong, rdzhabarov, tatianashp and 14 others. · View Herald TranscriptJan 5 2021, 1:54 PM
youngar requested review of this revision.Jan 5 2021, 1:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 5 2021, 1:54 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
mehdi_amini accepted this revision.Jan 5 2021, 1:58 PM
This revision is now accepted and ready to land.Jan 5 2021, 1:58 PM
Harbormaster completed remote builds in B84114: Diff 314716.Jan 5 2021, 2:36 PM
Closed by commit rG91f17ba24e86: [mlir] Print the correct tool name in mlirTranslateMain (authored by youngar). · Explain WhyJan 5 2021, 7:17 PM
This revision was automatically updated to reflect the committed changes.
youngar added a commit: rG91f17ba24e86: [mlir] Print the correct tool name in mlirTranslateMain.

Revision Contents

PathSize
mlir/
lib/
Translation/
2 lines
test/
mlir-translate/
2 lines

Diff 314776

mlir/lib/Translation/Translation.cpp

Show First 20 Lines • Show All 151 Lines • ▼ Show 20 LinesLogicalResult mlir::mlirTranslateMain(int argc, char **argv,
llvm::InitLLVM y(argc, argv); llvm::InitLLVM y(argc, argv);
// Add flags for all the registered translations. // Add flags for all the registered translations.
llvm::cl::opt<const TranslateFunction *, false, TranslationParser> llvm::cl::opt<const TranslateFunction *, false, TranslationParser>
translationRequested("", llvm::cl::desc("Translation to perform"), translationRequested("", llvm::cl::desc("Translation to perform"),
llvm::cl::Required); llvm::cl::Required);
registerAsmPrinterCLOptions(); registerAsmPrinterCLOptions();
registerMLIRContextCLOptions(); registerMLIRContextCLOptions();
llvm::cl::ParseCommandLineOptions(argc, argv, "MLIR translation driver\n"); llvm::cl::ParseCommandLineOptions(argc, argv, toolName);
std::string errorMessage; std::string errorMessage;
auto input = openInputFile(inputFilename, &errorMessage); auto input = openInputFile(inputFilename, &errorMessage);
if (!input) { if (!input) {
llvm::errs() << errorMessage << "\n"; llvm::errs() << errorMessage << "\n";
return failure(); return failure();
} }
Show All 38 Lines

mlir/test/mlir-translate/commandline.mlir

  • This file was added.
// RUN: mlir-translate --help | FileCheck %s
// CHECK: OVERVIEW: MLIR Translation Testing Tool
No newline at end of file