This is an archive of the discontinued LLVM Phabricator instance.

Differential D93950

[LLD] [MinGW] Pass the --demangle and --no-demangle options to the COFF linker
ClosedPublic

Authored by mstorsjo on Dec 30 2020, 1:06 PM.

Details

Reviewers
rnk
amccarth
Commits
rG248e3450fb8a: [LLD] [MinGW] Pass the --demangle and --no-demangle options to the COFF linker
Summary

Although, for some reason, the clang frontend strips out the --no-demangle option when passed via -Wl, see fb3d747fc6c36e819980e8a1f8e8804cdf9c8ef5.

Diff Detail

Event Timeline

mstorsjo created this revision.Dec 30 2020, 1:06 PM
Herald added a subscriber: dang. · View Herald TranscriptDec 30 2020, 1:06 PM
mstorsjo requested review of this revision.Dec 30 2020, 1:06 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 30 2020, 1:06 PM
Harbormaster completed remote builds in B83762: Diff 314145.Dec 30 2020, 1:34 PM
rnk accepted this revision.Jan 5 2021, 3:51 PM

lgtm

This revision is now accepted and ready to land.Jan 5 2021, 3:51 PM
Closed by commit rG248e3450fb8a: [LLD] [MinGW] Pass the --demangle and --no-demangle options to the COFF linker (authored by mstorsjo). · Explain WhyJan 7 2021, 12:08 AM
This revision was automatically updated to reflect the committed changes.
mstorsjo added a commit: rG248e3450fb8a: [LLD] [MinGW] Pass the --demangle and --no-demangle options to the COFF linker.

Revision Contents

PathSize
lld/
MinGW/
5 lines
3 lines
test/
MinGW/
9 lines

Diff 315057

lld/MinGW/Driver.cpp

Show First 20 Lines • Show All 314 Lines • ▼ Show 20 Linesbool mingw::link(ArrayRef<const char *> argsArr, bool canExitEarly,
if (args.hasFlag(OPT_no_insert_timestamp, OPT_insert_timestamp, false)) if (args.hasFlag(OPT_no_insert_timestamp, OPT_insert_timestamp, false))
add("-timestamp:0"); add("-timestamp:0");
if (args.hasFlag(OPT_gc_sections, OPT_no_gc_sections, false)) if (args.hasFlag(OPT_gc_sections, OPT_no_gc_sections, false))
add("-opt:ref"); add("-opt:ref");
else else
add("-opt:noref"); add("-opt:noref");
if (args.hasFlag(OPT_demangle, OPT_no_demangle, true))
add("-demangle");
else
add("-demangle:no");
if (args.hasFlag(OPT_enable_auto_import, OPT_disable_auto_import, true)) if (args.hasFlag(OPT_enable_auto_import, OPT_disable_auto_import, true))
add("-auto-import"); add("-auto-import");
else else
add("-auto-import:no"); add("-auto-import:no");
if (args.hasFlag(OPT_enable_runtime_pseudo_reloc, if (args.hasFlag(OPT_enable_runtime_pseudo_reloc,
OPT_disable_runtime_pseudo_reloc, true)) OPT_disable_runtime_pseudo_reloc, true))
add("-runtime-pseudo-reloc"); add("-runtime-pseudo-reloc");
else else
▲ Show 20 Lines • Show All 101 Lines • Show Last 20 Lines

lld/MinGW/Options.td

Show All 22 Lines
def L: JoinedOrSeparate<["-"], "L">, MetaVarName<"<dir>">, def L: JoinedOrSeparate<["-"], "L">, MetaVarName<"<dir>">,
HelpText<"Add a directory to the library search path">; HelpText<"Add a directory to the library search path">;
defm allow_multiple_definition: B<"allow-multiple-definition", defm allow_multiple_definition: B<"allow-multiple-definition",
"Allow multiple definitions", "Allow multiple definitions",
"Do not allow multiple definitions (default)">; "Do not allow multiple definitions (default)">;
def Bdynamic: F<"Bdynamic">, HelpText<"Link against shared libraries">; def Bdynamic: F<"Bdynamic">, HelpText<"Link against shared libraries">;
def Bstatic: F<"Bstatic">, HelpText<"Do not link against shared libraries">; def Bstatic: F<"Bstatic">, HelpText<"Do not link against shared libraries">;
defm demangle: B<"demangle",
"Demangle symbol names (default)",
"Do not demangle symbol names">;
def disable_auto_import: F<"disable-auto-import">, def disable_auto_import: F<"disable-auto-import">,
HelpText<"Don't automatically import data symbols from other DLLs without dllimport">; HelpText<"Don't automatically import data symbols from other DLLs without dllimport">;
def disable_runtime_pseudo_reloc: F<"disable-runtime-pseudo-reloc">, def disable_runtime_pseudo_reloc: F<"disable-runtime-pseudo-reloc">,
HelpText<"Don't do automatic imports that require runtime fixups">; HelpText<"Don't do automatic imports that require runtime fixups">;
defm dynamicbase: B<"dynamicbase", "Enable ASLR", "Disable ASLR">; defm dynamicbase: B<"dynamicbase", "Enable ASLR", "Disable ASLR">;
def enable_auto_import: F<"enable-auto-import">, def enable_auto_import: F<"enable-auto-import">,
HelpText<"Automatically import data symbols from other DLLs where needed">; HelpText<"Automatically import data symbols from other DLLs where needed">;
def enable_runtime_pseudo_reloc: F<"enable-runtime-pseudo-reloc">, def enable_runtime_pseudo_reloc: F<"enable-runtime-pseudo-reloc">,
▲ Show 20 Lines • Show All 95 Lines • Show Last 20 Lines

lld/test/MinGW/driver.test

Show First 20 Lines • Show All 279 Lines • ▼ Show 20 Lines
RUN: ld.lld -### -m i386pep foo.o --allow-multiple-definition --no-allow-multiple-definition | FileCheck -check-prefix NO_ALLOW_MULTIPLE_DEFINITION %s RUN: ld.lld -### -m i386pep foo.o --allow-multiple-definition --no-allow-multiple-definition | FileCheck -check-prefix NO_ALLOW_MULTIPLE_DEFINITION %s
RUN: ld.lld -### -m i386pep foo.o -allow-multiple-definition -no-allow-multiple-definition | FileCheck -check-prefix NO_ALLOW_MULTIPLE_DEFINITION %s RUN: ld.lld -### -m i386pep foo.o -allow-multiple-definition -no-allow-multiple-definition | FileCheck -check-prefix NO_ALLOW_MULTIPLE_DEFINITION %s
NO_ALLOW_MULTIPLE_DEFINITION-NOT: -force:multiple NO_ALLOW_MULTIPLE_DEFINITION-NOT: -force:multiple
RUN: ld.lld -### -m i386pep foo.o -wrap foo1 --wrap foo2 | FileCheck -check-prefix WRAP %s RUN: ld.lld -### -m i386pep foo.o -wrap foo1 --wrap foo2 | FileCheck -check-prefix WRAP %s
RUN: ld.lld -### -m i386pep foo.o -wrap=foo1 --wrap=foo2 | FileCheck -check-prefix WRAP %s RUN: ld.lld -### -m i386pep foo.o -wrap=foo1 --wrap=foo2 | FileCheck -check-prefix WRAP %s
WRAP: -wrap:foo1 -wrap:foo2 WRAP: -wrap:foo1 -wrap:foo2
RUN: ld.lld -### -m i386pep foo.o | FileCheck -check-prefix DEMANGLE %s
RUN: ld.lld -### -m i386pep foo.o -demangle | FileCheck -check-prefix DEMANGLE %s
RUN: ld.lld -### -m i386pep foo.o --demangle | FileCheck -check-prefix DEMANGLE %s
DEMANGLE: -demangle{{ }}
RUN: ld.lld -### -m i386pep foo.o -no-demangle | FileCheck -check-prefix NO-DEMANGLE %s
RUN: ld.lld -### -m i386pep foo.o --no-demangle | FileCheck -check-prefix NO-DEMANGLE %s
NO-DEMANGLE: -demangle:no