This is an archive of the discontinued LLVM Phabricator instance.

Differential D93816

[libc++] Mark [P0475] "LWG2511: guaranteed copy elision for piecewise construction" as Complete. NFC.
ClosedPublic

Authored by • Quuxplusone on Dec 25 2020, 1:27 PM.

Details

Reviewers
ldionne
EricWF
Group Reviewers
Restricted Project
Commits
rGcdd7cbf7b56b: [libc++] Mark [P0809] "LWG2831: Comparing Unordered Containers" as Nothing To…
Summary

The point of LWG2511 is basically just to make sure that we use tuple<Args&&...> instead of tuple<Args...> in a couple of places inside scoped_allocator_adaptor and inside pair. As far as I can tell, this has been true for libc++ since @EricWF's D27612 (and maybe even earlier than that).

Also mark [P0809] "LWG2831: Comparing Unordered Containers" as Nothing To Do.

LWG2831 simply removed some library UB because vendors were already doing the right thing. libc++ has always done the right thing (in this respect).

Diff Detail

Event Timeline

• Quuxplusone requested review of this revision.Dec 25 2020, 1:27 PM
• Quuxplusone created this revision.
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 25 2020, 1:27 PM
Herald added a subscriber: libcxx-commits. · View Herald Transcript
• Quuxplusone updated this revision to Diff 313738.Dec 25 2020, 5:43 PM
• Quuxplusone edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B83504: Diff 313735.Dec 25 2020, 10:52 PM
Harbormaster completed remote builds in B83507: Diff 313738.Dec 26 2020, 6:04 AM
• Quuxplusone added a comment.Jan 8 2021, 2:07 PM

@EricWF @ldionne ping!

ldionne accepted this revision.Jan 8 2021, 2:24 PM

Thanks!

This revision is now accepted and ready to land.Jan 8 2021, 2:24 PM
Closed by commit rGcdd7cbf7b56b: [libc++] Mark [P0809] "LWG2831: Comparing Unordered Containers" as Nothing To… (authored by • arthur.j.odwyer). · Explain WhyJan 8 2021, 2:34 PM
This revision was automatically updated to reflect the committed changes.
• arthur.j.odwyer added a commit: rGcdd7cbf7b56b: [libc++] Mark [P0809] "LWG2831: Comparing Unordered Containers" as Nothing To….

Revision Contents

PathSize
libcxx/
docs/
2 lines

Diff 315523

libcxx/docs/Cxx2aStatusPaperStatus.csv

Show All 15 Lines
"`P0767R1 <https://wg21.link/P0767R1>`__","CWG","Deprecate POD","Albuquerque","|Complete|","7.0" "`P0767R1 <https://wg21.link/P0767R1>`__","CWG","Deprecate POD","Albuquerque","|Complete|","7.0"
"`P0768R1 <https://wg21.link/P0768R1>`__","CWG","Library Support for the Spaceship (Comparison) Operator","Albuquerque","|Complete|","" "`P0768R1 <https://wg21.link/P0768R1>`__","CWG","Library Support for the Spaceship (Comparison) Operator","Albuquerque","|Complete|",""
"`P0777R1 <https://wg21.link/P0777R1>`__","LWG","Treating Unnecessary ``decay``\ ","Albuquerque","|Complete|","7.0" "`P0777R1 <https://wg21.link/P0777R1>`__","LWG","Treating Unnecessary ``decay``\ ","Albuquerque","|Complete|","7.0"
"`P0122R7 <https://wg21.link/P0122R7>`__","LWG","<span>","Jacksonville","|Complete|","7.0" "`P0122R7 <https://wg21.link/P0122R7>`__","LWG","<span>","Jacksonville","|Complete|","7.0"
"`P0355R7 <https://wg21.link/P0355R7>`__","LWG","Extending chrono to Calendars and Time Zones","Jacksonville","|In Progress|","" "`P0355R7 <https://wg21.link/P0355R7>`__","LWG","Extending chrono to Calendars and Time Zones","Jacksonville","|In Progress|",""
"`P0551R3 <https://wg21.link/P0551R3>`__","LWG","Thou Shalt Not Specialize ``std``\ Function Templates!","Jacksonville","|Complete|","11.0" "`P0551R3 <https://wg21.link/P0551R3>`__","LWG","Thou Shalt Not Specialize ``std``\ Function Templates!","Jacksonville","|Complete|","11.0"
"`P0753R2 <https://wg21.link/P0753R2>`__","LWG","Manipulators for C++ Synchronized Buffered Ostream","Jacksonville","","" "`P0753R2 <https://wg21.link/P0753R2>`__","LWG","Manipulators for C++ Synchronized Buffered Ostream","Jacksonville","",""
"`P0754R2 <https://wg21.link/P0754R2>`__","LWG","<version>","Jacksonville","|Complete|","7.0" "`P0754R2 <https://wg21.link/P0754R2>`__","LWG","<version>","Jacksonville","|Complete|","7.0"
"`P0809R0 <https://wg21.link/P0809R0>`__","LWG","Comparing Unordered Containers","Jacksonville","","" "`P0809R0 <https://wg21.link/P0809R0>`__","LWG","Comparing Unordered Containers","Jacksonville","|Nothing To Do|",""
"`P0858R0 <https://wg21.link/P0858R0>`__","LWG","Constexpr iterator requirements","Jacksonville","","" "`P0858R0 <https://wg21.link/P0858R0>`__","LWG","Constexpr iterator requirements","Jacksonville","",""
"`P0905R1 <https://wg21.link/P0905R1>`__","CWG","Symmetry for spaceship","Jacksonville","","" "`P0905R1 <https://wg21.link/P0905R1>`__","CWG","Symmetry for spaceship","Jacksonville","",""
"`P0966R1 <https://wg21.link/P0966R1>`__","LWG","``string::reserve``\ Should Not Shrink","Jacksonville","|Complete| [#note-P0966]_","12.0" "`P0966R1 <https://wg21.link/P0966R1>`__","LWG","``string::reserve``\ Should Not Shrink","Jacksonville","|Complete| [#note-P0966]_","12.0"
"","","","","","" "","","","","",""
"`P0019R8 <https://wg21.link/P0019R8>`__","LWG","Atomic Ref","Rapperswil","","" "`P0019R8 <https://wg21.link/P0019R8>`__","LWG","Atomic Ref","Rapperswil","",""
"`P0458R2 <https://wg21.link/P0458R2>`__","LWG","Checking for Existence of an Element in Associative Containers","Rapperswil","|Complete|","" "`P0458R2 <https://wg21.link/P0458R2>`__","LWG","Checking for Existence of an Element in Associative Containers","Rapperswil","|Complete|",""
"`P0475R1 <https://wg21.link/P0475R1>`__","LWG","LWG 2511: guaranteed copy elision for piecewise construction","Rapperswil","|Complete|","" "`P0475R1 <https://wg21.link/P0475R1>`__","LWG","LWG 2511: guaranteed copy elision for piecewise construction","Rapperswil","|Complete|",""
"`P0476R2 <https://wg21.link/P0476R2>`__","LWG","Bit-casting object representations","Rapperswil","","" "`P0476R2 <https://wg21.link/P0476R2>`__","LWG","Bit-casting object representations","Rapperswil","",""
▲ Show 20 Lines • Show All 163 Lines • Show Last 20 Lines