This is an archive of the discontinued LLVM Phabricator instance.

Differential D93527

[TableGen] NFC: Rename variables in OptParserEmitter
ClosedPublic

Authored by jansvoboda11 on Dec 18 2020, 2:19 AM.

Details

Reviewers
dexonsmith
Bigcheese
Commits
rG164bcbd40e6d: [TableGen] NFC: Rename variables in OptParserEmitter
Summary

Switch to the LLVM naming convention.

Diff Detail

Event Timeline

jansvoboda11 requested review of this revision.Dec 18 2020, 2:19 AM
jansvoboda11 created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptDec 18 2020, 2:19 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B82924: Diff 312732.Dec 18 2020, 2:19 AM
dexonsmith accepted this revision.Dec 18 2020, 1:29 PM

LGTM.

This revision is now accepted and ready to land.Dec 18 2020, 1:29 PM
This revision was landed with ongoing or failed builds.Dec 21 2020, 3:37 AM
Closed by commit rG164bcbd40e6d: [TableGen] NFC: Rename variables in OptParserEmitter (authored by jansvoboda11). · Explain Why
This revision was automatically updated to reflect the committed changes.
jansvoboda11 added a commit: rG164bcbd40e6d: [TableGen] NFC: Rename variables in OptParserEmitter.

Revision Contents

PathSize
llvm/
utils/
TableGen/
12 lines

Diff 313071

llvm/utils/TableGen/OptParserEmitter.cpp

Show First 20 Lines • Show All 214 Lines • ▼ Show 20 Linesvoid EmitOptParser(RecordKeeper &Records, raw_ostream &OS) {
array_pod_sort(Opts.begin(), Opts.end(), CompareOptionRecords); array_pod_sort(Opts.begin(), Opts.end(), CompareOptionRecords);
// Generate prefix groups. // Generate prefix groups.
typedef SmallVector<SmallString<2>, 2> PrefixKeyT; typedef SmallVector<SmallString<2>, 2> PrefixKeyT;
typedef std::map<PrefixKeyT, std::string> PrefixesT; typedef std::map<PrefixKeyT, std::string> PrefixesT;
PrefixesT Prefixes; PrefixesT Prefixes;
Prefixes.insert(std::make_pair(PrefixKeyT(), "prefix_0")); Prefixes.insert(std::make_pair(PrefixKeyT(), "prefix_0"));
unsigned CurPrefix = 0; unsigned CurPrefix = 0;
for (const Record &R : llvm::make_pointee_range(Opts)) { for (const Record &R : llvm::make_pointee_range(Opts)) {
std::vector<StringRef> prf = R.getValueAsListOfStrings("Prefixes"); std::vector<StringRef> RPrefixes = R.getValueAsListOfStrings("Prefixes");
PrefixKeyT prfkey(prf.begin(), prf.end()); PrefixKeyT PrefixKey(RPrefixes.begin(), RPrefixes.end());
unsigned NewPrefix = CurPrefix + 1; unsigned NewPrefix = CurPrefix + 1;
if (Prefixes.insert(std::make_pair(prfkey, (Twine("prefix_") + std::string Prefix = (Twine("prefix_") + Twine(NewPrefix)).str();
Twine(NewPrefix)).str())).second) if (Prefixes.insert(std::make_pair(PrefixKey, Prefix)).second)
CurPrefix = NewPrefix; CurPrefix = NewPrefix;
} }
// Dump prefixes. // Dump prefixes.
OS << "/////////\n"; OS << "/////////\n";
OS << "// Prefixes\n\n"; OS << "// Prefixes\n\n";
OS << "#ifdef PREFIX\n"; OS << "#ifdef PREFIX\n";
▲ Show 20 Lines • Show All 58 Lines • ▼ Show 20 Linesvoid EmitOptParser(RecordKeeper &Records, raw_ostream &OS) {
} }
OS << "\n"; OS << "\n";
OS << "//////////\n"; OS << "//////////\n";
OS << "// Options\n\n"; OS << "// Options\n\n";
auto WriteOptRecordFields = [&](raw_ostream &OS, const Record &R) { auto WriteOptRecordFields = [&](raw_ostream &OS, const Record &R) {
// The option prefix; // The option prefix;
std::vector<StringRef> prf = R.getValueAsListOfStrings("Prefixes"); std::vector<StringRef> RPrefixes = R.getValueAsListOfStrings("Prefixes");
OS << Prefixes[PrefixKeyT(prf.begin(), prf.end())] << ", "; OS << Prefixes[PrefixKeyT(RPrefixes.begin(), RPrefixes.end())] << ", ";
// The option string. // The option string.
emitNameUsingSpelling(OS, R); emitNameUsingSpelling(OS, R);
// The option identifier name. // The option identifier name.
OS << ", " << getOptionName(R); OS << ", " << getOptionName(R);
// The option kind. // The option kind.
▲ Show 20 Lines • Show All 168 Lines • Show Last 20 Lines