Page MenuHomePhabricator

[libc++] [CI] Install Tip-of-Trunk clang.
ClosedPublic

Authored by curdeius on Dec 18 2020, 12:19 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rGb6fb0209b6d4: [libc++] [CI] Install Tip-of-Trunk clang.
Summary
  • Check created symlinks.

Diff Detail

Event Timeline

curdeius created this revision.Dec 18 2020, 12:19 AM
curdeius requested review of this revision.Dec 18 2020, 12:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 18 2020, 12:19 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript

I can make it work without the LLVM_TOT_VERSION by getting $LLVM_VERSION from llvm.sh script and putting it into a temporary file (because I can't store it in a variable during docker build). Would it be better?
Another thing, should we prefer installing a fixed version of clang-format or ToT? The latter has improvements for concepts for example, but may (theoretically) be unstable.

curdeius updated this revision to Diff 312713.Dec 18 2020, 1:07 AM
  • Put current LLVM_VERSION in file and use it later.
  • Make script completely automatic. Don't rely on LLVM_VERSION variable from llvm.sh.
ldionne accepted this revision.Jan 6 2021, 3:06 PM

This LGTM - did you test it? Build the image and run one of the build bots (./libcxx/utils/ci/run-buildbot whatever). If it passes, LGTM.

This revision is now accepted and ready to land.Jan 6 2021, 3:06 PM

Yes, built and tested. Works fine. Will land it soon.

This revision was automatically updated to reflect the committed changes.