Page MenuHomePhabricator

WimLeflere (Wim Leflere)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 2 2018, 3:13 AM (154 w, 12 h)

Recent Activity

Jan 22 2021

WimLeflere added a comment to D93912: [libc++][P1679] add string contains.

The paper is fully implemented.

Jan 22 2021, 9:07 AM · Restricted Project

Jan 19 2021

WimLeflere updated the diff for D93912: [libc++][P1679] add string contains.

Rebased and removed unused bool return from basic_string tests.

Jan 19 2021, 9:03 AM · Restricted Project

Jan 18 2021

WimLeflere added a comment to D93912: [libc++][P1679] add string contains.

@ldionne: LGTM except that the non-constexpr tests no longer need to return true; from bool test() — they could do void test() for now.
Also, I don't think this will rebase as-is on generate_feature_test_macro_components.py, will it? You'll have to add the entry for __cpp_lib_string_contains, which will be easy — but I notice that it will be a divergence from what's literally in https://isocpp.org/std/standing-documents/sd-6-sg10-feature-test-recommendations as of this writing. I would bet that's fine; I'm just bringing it up for awareness.

The current direction on constexpr/noexcept sounds great to me.

Jan 18 2021, 11:59 PM · Restricted Project
WimLeflere added a comment to D94530: [libc++] improve feature test macro script.

Do you need help committing this? If so, please provide Author Name <email@domain>. Thanks!

Jan 18 2021, 12:05 PM · Restricted Project
WimLeflere added a comment to D93912: [libc++][P1679] add string contains.

Any action required from my side?

Jan 18 2021, 11:06 AM · Restricted Project
WimLeflere added a comment to D94530: [libc++] improve feature test macro script.

Any action required from my side?

Jan 18 2021, 11:06 AM · Restricted Project

Jan 12 2021

WimLeflere updated the diff for D94530: [libc++] improve feature test macro script.

removed c++11 from the std dialects and updated the code

Jan 12 2021, 1:57 PM · Restricted Project
WimLeflere added inline comments to D94530: [libc++] improve feature test macro script.
Jan 12 2021, 12:15 PM · Restricted Project
WimLeflere updated the diff for D94530: [libc++] improve feature test macro script.

replaced nr with number

Jan 12 2021, 12:08 PM · Restricted Project
WimLeflere updated the diff for D94530: [libc++] improve feature test macro script.
  • added assert for last std not numeric
  • replaced f-strings with template.format
Jan 12 2021, 11:49 AM · Restricted Project
WimLeflere requested review of D94530: [libc++] improve feature test macro script.
Jan 12 2021, 10:07 AM · Restricted Project
WimLeflere updated the diff for D93912: [libc++][P1679] add string contains.

removed constexpr string test FIXME

Jan 12 2021, 12:19 AM · Restricted Project
WimLeflere added inline comments to D93912: [libc++][P1679] add string contains.
Jan 12 2021, 12:17 AM · Restricted Project

Jan 11 2021

WimLeflere updated the diff for D93912: [libc++][P1679] add string contains.
  • removed constexpr from string test functions
  • removed noexcept assert for const char* overload
Jan 11 2021, 12:24 PM · Restricted Project
WimLeflere updated the diff for D93912: [libc++][P1679] add string contains.

added paper nr to FIXME

Jan 11 2021, 12:15 PM · Restricted Project
WimLeflere added inline comments to D93912: [libc++][P1679] add string contains.
Jan 11 2021, 10:42 AM · Restricted Project
WimLeflere updated the diff for D93912: [libc++][P1679] add string contains.
  • replaced constexpr/noexcept macros with keywords
  • made const char* overload not noexcept
  • disabled constexpr std::string tests
  • used c++2a label for test support
Jan 11 2021, 10:38 AM · Restricted Project

Jan 10 2021

WimLeflere updated the diff for D93912: [libc++][P1679] add string contains.

Setting correct repo

Jan 10 2021, 6:01 AM · Restricted Project
WimLeflere abandoned D94122: [libc++][P0457] add string starts ends with feature test macro.

Redundant with D93830

Jan 10 2021, 4:03 AM · Restricted Project
WimLeflere updated the diff for D93912: [libc++][P1679] add string contains.

Added extra testcases

Jan 10 2021, 4:01 AM · Restricted Project

Jan 8 2021

WimLeflere updated the diff for D93912: [libc++][P1679] add string contains.

Merged main with changes from D94227 and D93830.

Jan 8 2021, 11:08 AM · Restricted Project
WimLeflere added inline comments to D94227: [libc++] Add basic support for -std=c++2b..
Jan 8 2021, 7:51 AM · Restricted Project
WimLeflere added a comment to D93912: [libc++][P1679] add string contains.

This looks like WAY too much code for "add string contains".

Jan 8 2021, 3:29 AM · Restricted Project

Jan 7 2021

WimLeflere updated the diff for D93912: [libc++][P1679] add string contains.

Added feature test macro to script and updated generated files.

Jan 7 2021, 2:28 PM · Restricted Project

Jan 5 2021

WimLeflere requested review of D94122: [libc++][P0457] add string starts ends with feature test macro.
Jan 5 2021, 2:25 PM · Restricted Project
WimLeflere added a comment to D93912: [libc++][P1679] add string contains.

Where are the feature test macros defined?
__cpp_lib_string_contains should be added

The macro should be added to libcxx/utils/generate_feature_test_macro_components.py, then run the script to generate the proper macros and tests.

Jan 5 2021, 10:10 AM · Restricted Project

Dec 30 2020

WimLeflere updated the diff for D93912: [libc++][P1679] add string contains.

Applied review comments

  • replaced C++23 with C++2b and typedef with using
  • added constexpr test function to re-use for runtime and compile time testing
  • removed commented code and unnecessary constexpr_char_traits
Dec 30 2020, 6:25 AM · Restricted Project
WimLeflere added inline comments to D93912: [libc++][P1679] add string contains.
Dec 30 2020, 1:43 AM · Restricted Project
WimLeflere added a comment to D93912: [libc++][P1679] add string contains.

Where are the feature test macros defined?
__cpp_lib_string_contains should be added

Dec 30 2020, 1:30 AM · Restricted Project

Dec 29 2020

WimLeflere requested review of D93912: [libc++][P1679] add string contains.
Dec 29 2020, 12:11 PM · Restricted Project

Jul 25 2018

WimLeflere added a comment to D48827: [clang-format ]Extend IncludeCategories regex documentation.

I don't have commit access, can someone else commit this change?

Jul 25 2018, 1:31 AM

Jul 5 2018

WimLeflere added a comment to D48827: [clang-format ]Extend IncludeCategories regex documentation.

Who can merge these changes?
Or does this happen automatically?

Jul 5 2018, 11:55 PM
WimLeflere updated the diff for D48827: [clang-format ]Extend IncludeCategories regex documentation.

Added the documentation to the header file.
Also had to update dump_format_style.py because it was not loading the IncludeStyle header file.

Jul 5 2018, 12:25 AM

Jul 2 2018

WimLeflere created D48827: [clang-format ]Extend IncludeCategories regex documentation.
Jul 2 2018, 4:36 AM