Page MenuHomePhabricator

[libc++] Install git-clang-format on CI nodes.
ClosedPublic

Authored by ldionne on Dec 14 2020, 3:32 AM.

Details

Reviewers
curdeius
ldionne
Group Reviewers
Restricted Project
Commits
rGd69fc6629d07: [libc++] Install git-clang-format on CI nodes.
Summary

Two problems fixed:

  • an old version of clang-format get installed by default (6.0).
  • git-clang-format is not present, only git-clang-format-<version> (e.g. git-clang-format-6.0).

Solution:

  • install clang-format-11 with explicit version
  • make symlink git-clang-format to the latest version of git-clang-format-<version>

Diff Detail

Event Timeline

curdeius created this revision.Dec 14 2020, 3:32 AM
curdeius requested review of this revision.Dec 14 2020, 3:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 14 2020, 3:32 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript

I have no access to a macOS machine to verify/fix macos-ci-setup script.

BTW, @ldionne, feel free to commandeer the revision if it makes things easier.

ldionne commandeered this revision.Dec 16 2020, 1:33 PM
ldionne edited reviewers, added: curdeius; removed: ldionne.
ldionne accepted this revision.Dec 16 2020, 1:36 PM

Actually, this LGTM as-is. On macOS, brew install clang-format also installs git-clang-format.

This revision is now accepted and ready to land.Dec 16 2020, 1:36 PM
This revision was automatically updated to reflect the committed changes.