EmulateInstructionMIPS64 has been modified to use llvm::MCDisassembler instead of duplicating the decoding logic. Added emulation of few branch instructions for software single stepping.
Just move stuff from the header to the .cpp file and this is good to go.
|13–25 ↗||(On Diff #24528)|
These includes should go into the .cpp file only.
|83–107 ↗||(On Diff #24528)|
Move to .cpp
|140–166 ↗||(On Diff #24528)|
use "const llvm::MCInst &" so we don't have to know what an llvm::MCInst is in the header file and forward declare llvm::MCInst at top.
|175–180 ↗||(On Diff #24528)|
Forward declare all llvm:: types so we don't have to include the headers.
Minor nit pick: we might want to make the arguments that currently take a "llvm::MCInst &" take "const llvm::MCInst &". Not sure if any function calls use non const functions, so this shouldn't hold up the patch.
|124–140 ↗||(On Diff #24598)|
Can we make these all "const llvm::MCInst &" arguments?