LNT: Sort testsuites ascendingly

[tnfchris]

Summary

When running a large number of testsuites having them sorted
alphabetically makes them easier to find.

This also allows us to group testsuite by prefixing them with
language.

[thopre]

lnt/server/db/v4db.py

59

Shouldn't you use an OrderedDict instead of dict to guarantee the ordering will be the same as when inserted?

[tnfchris]

lnt/server/db/v4db.py

59

From what I understand, in Python 3, dict is guaranteed to keep order during insertion https://mail.python.org/pipermail/python-dev/2017-December/151283.html

[thopre]

LGTM

lnt/server/db/v4db.py

59

Ah yes indeed, https://docs.python.org/3/library/stdtypes.html#dict has:

Changed in version 3.7: Dictionary order is guaranteed to be insertion order. This behavior was an implementation detail of CPython from 3.6.

[thopre]

lnt/server/db/v4db.py

59

Wait, we currently only require Python 3.6 or later because that's what lots of distribution provide. Could you make it use OrderedDict instead?

[tnfchris]

lnt/server/db/v4db.py

59

Wait, we currently only require Python 3.6 or later because that's what lots of distribution provide. Could you make it use OrderedDict instead?

Sure, but I don't think it matters much though.. This isn't a correctness thing but just a way to attempt to provide some structure. Regardless of the order here other functions can change this.

[thopre]

lnt/server/db/v4db.py

59

Ah yes, sorry, forgot what the point of the patch was.

lnt/server/db/v4db.py

                 continue
             tsdb = lnt.server.db.testsuitedb.TestSuiteDB(self, name, suite)
             self.testsuite[name] = tsdb
+        # Order testuites alphabetically to get groupings
+        self.testsuite = dict (sorted (self.testsuite.items()))
 
     def __init__(self, path, config, baseline_revision=0):
         # If the path includes no database type, assume sqlite.