This is an archive of the discontinued LLVM Phabricator instance.

scudo: Shrink secondary header and cache entry size by a word on Linux. NFCI.
ClosedPublic

Authored by pcc on Dec 9 2020, 1:33 PM.

Details

Summary

Normally compilers will allocate space for struct fields even if the
field is an empty struct. Use the [[no_unique_address]] attribute to
suppress that behavior. This attribute that was introduced in C++20,
but compilers that do not support [[no_unique_address]] will ignore
it since it uses C++11 attribute syntax.

Diff Detail

Event Timeline

pcc requested review of this revision.Dec 9 2020, 1:33 PM
pcc created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptDec 9 2020, 1:33 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
eugenis accepted this revision.Dec 9 2020, 1:50 PM

LGTM

This revision is now accepted and ready to land.Dec 9 2020, 1:50 PM
This revision was landed with ongoing or failed builds.Dec 9 2020, 2:15 PM
This revision was automatically updated to reflect the committed changes.