[DFSan] Add custom wrapper for getsockopt.

[morehouse]

Summary

The wrapper clears shadow for optval and optlen when written.

[stephan.yichao.zhao]

compiler-rt/test/dfsan/custom.cpp

911

add or modify a test case when the returned optlen can be smaller than its input?

This seems an interesting case to test.

[morehouse]

• Pass a larger buf than is written to by getsockopt.

compiler-rt/lib/dfsan/dfsan_custom.cpp

__dfsw_socketpair(int domain, int type, int protocol, int sv[2],
   int ret = socketpair(domain, type, protocol, sv);
   *ret_label = 0;
   if (ret == 0) {
     dfsan_set_label(0, sv, sizeof(*sv) * 2);
   }
   return ret;
 }
 
+SANITIZER_INTERFACE_ATTRIBUTE int __dfsw_getsockopt(
+    int sockfd, int level, int optname, void *optval, socklen_t *optlen,
+    dfsan_label sockfd_label, dfsan_label level_label,
+    dfsan_label optname_label, dfsan_label optval_label,
+    dfsan_label optlen_label, dfsan_label *ret_label) {
+  int ret = getsockopt(sockfd, level, optname, optval, optlen);
+  if (ret != -1 && optval && optlen) {
+    dfsan_set_label(0, optlen, sizeof(*optlen));
+    dfsan_set_label(0, optval, *optlen);
+  }
+  *ret_label = 0;
+  return ret;
+}
+
 // Type of the trampoline function passed to the custom version of
 // dfsan_set_write_callback.
 typedef void (*write_trampoline_t)(
     void *callback,
     int fd, const void *buf, ssize_t count,
     dfsan_label fd_label, dfsan_label buf_label, dfsan_label count_label);
 
 // Calls to dfsan_set_write_callback() set the values in this struct.

compiler-rt/lib/dfsan/done_abilist.txt

 fun:epoll_wait=custom
 fun:fgets=custom
 fun:fstat=custom
 fun:getcwd=custom
 fun:get_current_dir_name=custom
 fun:gethostname=custom
 fun:getrlimit=custom
 fun:getrusage=custom
+fun:getsockopt=custom
 fun:nanosleep=custom
 fun:pread=custom
 fun:read=custom
 fun:socketpair=custom
 fun:stat=custom
 fun:time=custom
 
 # Functions that produce an output that depend on the input (propagate the

compiler-rt/test/dfsan/custom.cpp

void test_socketpair() {
 
   dfsan_set_label(i_label, fd, sizeof(fd));
   int rv = socketpair(PF_LOCAL, SOCK_STREAM, 0, fd);
   assert(rv == 0);
   ASSERT_ZERO_LABEL(rv);
   ASSERT_READ_ZERO_LABEL(fd, sizeof(fd));
 }
 
+void test_getsockopt() {
+  int sockfd = socket(AF_UNIX, SOCK_DGRAM, 0);
+  assert(sockfd != -1);
+
+  int optval = -1;
+  socklen_t optlen = sizeof(optval);
+  dfsan_set_label(i_label, &optval, sizeof(optval));
+  dfsan_set_label(i_label, &optlen, sizeof(optlen));
+  int ret = getsockopt(sockfd, SOL_SOCKET, SO_KEEPALIVE, &optval, &optlen);
+  assert(ret != -1);
+  assert(optval == 0);
+  assert(optlen == sizeof(optval));
+  ASSERT_ZERO_LABEL(ret);
+  ASSERT_ZERO_LABEL(optval);
+  ASSERT_ZERO_LABEL(optlen);
+
+  close(sockfd);
+}
+
 void test_write() {
   int fd = open("/dev/null", O_WRONLY);
 
   char buf[] = "a string";
   int len = strlen(buf);
 
   // The result of a write always unlabeled.
   int res = write(fd, buf, len);
#endif
   test_fgets();
   test_fstat();
   test_get_current_dir_name();
   test_getcwd();
   test_gethostname();
   test_getpwuid_r();
   test_getrlimit();
   test_getrusage();
+  test_getsockopt();
   test_gettimeofday();
   test_inet_pton();
   test_localtime_r();
   test_memchr();
   test_memcmp();
   test_memcpy();
   test_memset();
   test_nanosleep();