Don't print a type of variable in Address::Dump if it's unknown (i.e. nullptr)

[ki.stfu]

Summary

This patch fixes dereferencing of nullptr in case when GetType() returns that.

[granata.enrico]

source/Core/Address.cpp

753

Just a minor idea for an improvement here

if (type)

s->Printf (", type = \"%s\"", type->GetName().GetCString());

else

s->Printf (", type = <unknown>");

Looks to me like printing some marker when we can't figure out the type is better than just leaving it out entirely

[ki.stfu]

source/Core/Address.cpp

753

thx for the suggestion. I'll do that.

[ki.stfu]

Print <unknown> when type is null

[clayborg]

Looks fine.

source/Core/Address.cpp

case DumpStyleDetailedSymbolContext:
                     
                     const size_t num_variables = variable_list.GetSize();
                     for (size_t var_idx = 0; var_idx < num_variables; ++var_idx)
                     {
                         Variable *var = variable_list.GetVariableAtIndex (var_idx).get();
                         if (var && var->LocationIsValidForAddress (*this))
                         {
                             s->Indent();
-                            s->Printf ("   Variable: id = {0x%8.8" PRIx64 "}, name = \"%s\", type= \"%s\", location =",
+                            s->Printf ("   Variable: id = {0x%8.8" PRIx64 "}, name = \"%s\"",
                                        var->GetID(),
-                                       var->GetName().GetCString(),
-                                       var->GetType()->GetName().GetCString());
+                                       var->GetName().GetCString());
+                            Type *type = var->GetType();
+                            if (type)
+                                s->Printf(", type = \"%s\"", type->GetName().GetCString());
+                            else
+                                s->PutCString(", type = <unknown>");
+                            s->PutCString(", location = ");
                             var->DumpLocationForAddress(s, *this);
                             s->PutCString(", decl = ");
                             var->GetDeclaration().DumpStopContext(s, false);
                             s->EOL();
                         }
                     }
                 }
             }