Page MenuHomePhabricator

granata.enrico (Enrico Granata)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 15 2014, 1:32 PM (261 w, 3 d)

Recent Activity

Aug 23 2019

granata.enrico resigned from D66654: 2/2: Process formatters in reverse-chronological order.

I'm not working on LLDB anymore. Sorry about that.

Aug 23 2019, 10:44 AM · Restricted Project, Restricted Project

Oct 22 2018

granata.enrico resigned from D53506: [ClangASTContext] Extract VTable pointers from C++ objects.
Oct 22 2018, 9:43 AM · Restricted Project

Sep 2 2018

granata.enrico resigned from D51569: Hold GIL while allocating memory for PythonString..

I don't work on LLDB anymore. I am sure Greg will do a fine job reviewing!

Sep 2 2018, 7:26 PM

Jun 27 2018

granata.enrico added a comment to D48658: Fix and simplify lldb.command decorator.

Thanks for doing this work.

Jun 27 2018, 9:58 AM
granata.enrico removed a reviewer for D48658: Fix and simplify lldb.command decorator: granata.enrico.
Jun 27 2018, 9:57 AM

Jun 2 2017

granata.enrico resigned from D33855: Fix type category matching to source language..

On the surface, that looks correct to me. However I don't work on LLDB anymore and have been out of the loop enough that I don't feel comfortable approving this change. I believe Jim Ingham is Data Formatter Overlord these days.

Jun 2 2017, 6:30 PM · Restricted Project

Jan 24 2017

granata.enrico resigned from D29078: This patch implements a command to access and manipulate the Intel(R) MPX Boundary Tables..

I don't work on LLDB anymore. Resigning as reviewer. Best of luck with your patch :-)

Jan 24 2017, 10:15 AM

Nov 29 2016

granata.enrico resigned from D13617: Fix ref-counting of Python objects.

I am not an Apple employee working on LLDB anymore

Nov 29 2016, 10:05 AM · Restricted Project
granata.enrico resigned from D19086: [clang-analyzer] fix warnings emitted on lldb code base.

I am not an Apple employee working on LLDB anymore

Nov 29 2016, 10:05 AM
granata.enrico resigned from D19092: Fix Android build after r266267.

I am not an Apple employee working on LLDB anymore

Nov 29 2016, 10:05 AM
granata.enrico resigned from D26757: Fix broken escaping of commands in the build.

I am not an Apple employee working on LLDB anymore

Nov 29 2016, 10:04 AM

Nov 16 2016

granata.enrico added inline comments to D26757: Fix broken escaping of commands in the build.
Nov 16 2016, 11:40 AM
granata.enrico added a reviewer for D26757: Fix broken escaping of commands in the build: beanz.

Chris, can you take a look at this? I am far from a CMake expert

Nov 16 2016, 11:38 AM

Nov 9 2016

granata.enrico added a comment to D26403: Display the pointer value in the libstdc++ unique_ptr summary.

Makes sense. Feel free to commit.

Nov 9 2016, 9:55 AM

Nov 8 2016

granata.enrico accepted D26403: Display the pointer value in the libstdc++ unique_ptr summary.

Make what you will of my suggestion above, but in general the reasoning looks good

Nov 8 2016, 10:36 AM

Oct 19 2016

granata.enrico added a comment to D25726: Improve the libstdc++ smart pointer formatters.

I see you already got a bunch of feedback on specific items. The overall idea looks good to me. I'll try to delve a little deeper in the code ASAP (I was out for a couple days and have some backlog...), but should be good to go assuming you address the feedback you already got + make sure tests work!

Oct 19 2016, 10:59 AM
granata.enrico added a comment to D25734: Add data formatter for libstdc++ unique_ptr.

I see you already got a bunch of feedback on specific items. The overall idea looks good to me. I'll try to delve a little deeper in the code ASAP (I was out for a couple days and have some backlog...), but should be good to go assuming you address the feedback you already got + make sure tests work!

Oct 19 2016, 10:58 AM

Sep 14 2016

granata.enrico added a comment to D24591: [LIT] First pass of LLDB LIT support.

@granata.enrico, we could migrate the existing tests into being executed by lit even if they aren't using lit's features, so if that direction is desired we could get everything in lit. That said, you shouldn't ever really have multiple incantations. Once we have reliable lit testing that is useful it should be connected to the "check-lldb" and "check-all" targets appropriately. Just because it runs more than one type of test doesn't mean you need multiple incantations, and more and varied testing is generally better for the quality of the product.

Sep 14 2016, 4:00 PM
granata.enrico added a comment to D24591: [LIT] First pass of LLDB LIT support.

One piece of concern that I have is the multiplication of things that "testing LLDB" means.

Sep 14 2016, 3:34 PM

Aug 31 2016

granata.enrico accepted D24074: Fixup TestPyObjSynthProvider.py and enable it again.
Aug 31 2016, 9:34 AM

Aug 29 2016

granata.enrico accepted D23951: Remove unused any_found local variable.

LGTM

Aug 29 2016, 10:54 AM
granata.enrico accepted D23950: Remove unused local variable.

Looks good to me

Aug 29 2016, 10:53 AM

Jul 27 2016

granata.enrico added a comment to D22863: Improve code of loading plugins that provide cmnds.

Everything Greg said makes total sense

Jul 27 2016, 3:25 PM

Jul 13 2016

granata.enrico added inline comments to D22286: [LLDB] Help text overhaul.
Jul 13 2016, 1:35 PM · Restricted Project

Jul 5 2016

granata.enrico added inline comments to D21984: Add data formatter for libstdc++ shared_ptr and weak_ptr.
Jul 5 2016, 11:19 AM
granata.enrico added inline comments to D21984: Add data formatter for libstdc++ shared_ptr and weak_ptr.
Jul 5 2016, 10:57 AM

Jun 24 2016

granata.enrico accepted D21680: Fix the libc++ pretty printers for the android NDK.

LGTM

Jun 24 2016, 10:25 AM

May 13 2016

granata.enrico accepted D20252: surface build error content through test event system.
May 13 2016, 5:42 PM
granata.enrico added inline comments to D20252: surface build error content through test event system.
May 13 2016, 2:54 PM

Apr 29 2016

granata.enrico added a comment to D19690: Split out console and file writing cases in TestCommandScriptImmediateOutput.

LGTM

Apr 29 2016, 10:49 AM
granata.enrico accepted D19690: Split out console and file writing cases in TestCommandScriptImmediateOutput.
Apr 29 2016, 10:11 AM

Apr 28 2016

granata.enrico added inline comments to D19690: Split out console and file writing cases in TestCommandScriptImmediateOutput.
Apr 28 2016, 8:27 PM
granata.enrico added a comment to D19633: Move TestCommandScriptImmediateOutput from PExpectTest to TestBase.

I don't think we are seeing this behavior on OS X (the failure to process sendline() calls) - but Todd Fiala might know more about that since he keeps a careful eye over our bots.

Apr 28 2016, 9:23 AM
granata.enrico added a comment to D19633: Move TestCommandScriptImmediateOutput from PExpectTest to TestBase.

Sure, that works. My only concern is that I'd like to keep the current PExpect-let's test writing to the console and see what happens behavior

Apr 28 2016, 9:18 AM

Apr 27 2016

granata.enrico added a comment to D19633: Move TestCommandScriptImmediateOutput from PExpectTest to TestBase.

My personal preference would be to split up the test cases. I'd really like to keep testing the immediate output to console scenario since it is interesting for - e.g. - kernel debugging at Apple.

Apr 27 2016, 5:07 PM
granata.enrico added a comment to D19633: Move TestCommandScriptImmediateOutput from PExpectTest to TestBase.

Why are we trying to do this in the first place?

Apr 27 2016, 4:03 PM

Apr 13 2016

granata.enrico added inline comments to D19086: [clang-analyzer] fix warnings emitted on lldb code base.
Apr 13 2016, 5:41 PM

Feb 25 2016

granata.enrico added inline comments to D17616: Add a set of new plugins to handle Java debugging.
Feb 25 2016, 4:46 PM

Feb 12 2016

granata.enrico accepted D17227: [TestLibCxxAtomic] Fix Makefile so that the test builds on Linux..
Feb 12 2016, 4:11 PM
granata.enrico requested changes to D17220: [CPlusPlus/LibCxxAtomic.cpp] Fix the path to the header file..

This include is actually not necessary. I am removing it outright.

Feb 12 2016, 3:16 PM

Jan 28 2016

granata.enrico added a comment to D16703: Fix TestDataFormatterScript for Linux..

That seems reasonable, yes.

Jan 28 2016, 9:24 PM

Jan 27 2016

granata.enrico added a comment to D15778: [lldb] Ignore breakpoints by default in SBFrame::EvaluateExpression.

It looks like this code is default constructing a SBExpressionOptions(), which at the end of the day is a fancy wrapper for EvaluateExpressionOptions

Jan 27 2016, 8:25 AM

Jan 21 2016

granata.enrico accepted D15209: Fix script import --allow-reload on Python 3.

Yes, I believe so.

Jan 21 2016, 9:00 AM

Jan 13 2016

granata.enrico accepted D16149: Delete char const** swig typemaps .

Ops, sorry, didn't notice the tid_t type map was actually added back later on in the patch. My bad.

Jan 13 2016, 1:22 PM
granata.enrico added a comment to D16149: Delete char const** swig typemaps .

Did you mean to delete the tid_t typemap as well?

Jan 13 2016, 1:00 PM

Dec 3 2015

granata.enrico added a comment to D15187: Improve the functionality of JSONNumber.

IIU my C++ correctly, this code covers neither int64_t nor double; it covers the unsigned variety of int64 - as well as any other unsigned integer type.

Dec 3 2015, 9:44 AM

Nov 9 2015

granata.enrico added a comment to D14524: Create a `PythonModule` class and add a root-level method for name lookup.

This seems reasonable to me. I would wait for Greg to OK it, just to be safe.

Nov 9 2015, 6:45 PM

Oct 29 2015

granata.enrico accepted D13878: Add data formatters for go strings and slices..

I think it's OK to land this, yes

Oct 29 2015, 2:25 PM

Oct 21 2015

granata.enrico accepted D13964: Fix libstdc++ data formatters on Ubuntu 15.10 x86_64.

Looks good to me

Oct 21 2015, 4:59 PM

Oct 20 2015

granata.enrico accepted D13778: [SBValue] Add a method GetNumChildren(uint32_t max).

Looks fine

Oct 20 2015, 4:58 PM
granata.enrico accepted D13836: Fix write-after-close of file descriptor in ScriptInterpreterPython.

Looks reasonable

Oct 20 2015, 10:33 AM
granata.enrico accepted D13902: [DataFormatters] Make libc++ list loop detection linear.

That looks reasonable. Of course, I assume you ran the test suite on OS X, including your new evil test!

Oct 20 2015, 10:30 AM

Oct 19 2015

granata.enrico added inline comments to D13878: Add data formatters for go strings and slices..
Oct 19 2015, 4:40 PM
granata.enrico added inline comments to D13799: [lldb-mi] display summary for simple types + refactor (use lldb formatting for all cases).
Oct 19 2015, 10:50 AM

Oct 16 2015

granata.enrico added inline comments to D13799: [lldb-mi] display summary for simple types + refactor (use lldb formatting for all cases).
Oct 16 2015, 11:11 AM
granata.enrico added inline comments to D13799: [lldb-mi] display summary for simple types + refactor (use lldb formatting for all cases).
Oct 16 2015, 10:28 AM

Oct 15 2015

granata.enrico added a comment to D13778: [SBValue] Add a method GetNumChildren(uint32_t max).

One alternative would be to have the num_children method on the synthetic provider itself be able to take an optional argument that is the max_count. That is, instead of defining

Oct 15 2015, 2:33 PM
granata.enrico resigned from D11099: [ClangASTType] Catch unhandled clang types at compile time.
Oct 15 2015, 1:34 PM
granata.enrico resigned from D7956: Python split [1/2] - File renames.
Oct 15 2015, 1:34 PM
granata.enrico resigned from D8069: Change lldb_assert() to use llvm::sys::PrintBacktrace.
Oct 15 2015, 1:34 PM
granata.enrico resigned from D7946: The great Python split.
Oct 15 2015, 1:33 PM
granata.enrico resigned from D6205: Mark 9 lldb unit tests for ubuntu as XFAIL.
Oct 15 2015, 1:33 PM
granata.enrico resigned from D6201: Add -std=c99 for building the test case of TestValueVarUpdate..
Oct 15 2015, 1:33 PM
granata.enrico resigned from D6177: R220718 broke some unit tests on linux.
Oct 15 2015, 1:33 PM
granata.enrico resigned from D6122: Fix compilation of DataFormatters/StringPrinter.cpp with GCC..
Oct 15 2015, 1:32 PM
granata.enrico added a comment to D13778: [SBValue] Add a method GetNumChildren(uint32_t max).

So, if I understand this correctly, this HasChildAtIndex() API returns a three-state int:

Oct 15 2015, 11:59 AM
granata.enrico requested changes to D13778: [SBValue] Add a method GetNumChildren(uint32_t max).

If so, why do you need this to be exposed as a call that LLDB knows about?

Oct 15 2015, 11:49 AM
granata.enrico added a comment to D13778: [SBValue] Add a method GetNumChildren(uint32_t max).

Is it possible to ask for concrete examples?

Oct 15 2015, 11:43 AM
granata.enrico added a comment to D13778: [SBValue] Add a method GetNumChildren(uint32_t max).

What do you plan to use this has_child_at_index call for?

Oct 15 2015, 11:28 AM
granata.enrico accepted D13657: [lldb] char summary provider.

Fine to get it in

Oct 15 2015, 10:41 AM
granata.enrico accepted D13577: Fix build with python disabled after r249597.

Looks fine to me

Oct 15 2015, 10:39 AM

Oct 14 2015

granata.enrico added a comment to D13657: [lldb] char summary provider.

So, if you do the explicit constructor change and handle the case of a nullptr Callback I think it should be good to go. Looking forward to it!

Oct 14 2015, 1:41 PM
granata.enrico added inline comments to D13657: [lldb] char summary provider.
Oct 14 2015, 12:05 PM
granata.enrico added a comment to D13699: RenderScript command for printing allocation contents..

Is there any reason why we need a special command here?

Oct 14 2015, 10:56 AM
granata.enrico added inline comments to D13657: [lldb] char summary provider.
Oct 14 2015, 10:53 AM
granata.enrico added a comment to D13657: [lldb] char summary provider.

Admittedly way simpler than my original idea. +1

Oct 14 2015, 10:53 AM

Oct 13 2015

granata.enrico added a comment to D13657: [lldb] char summary provider.

We are not supposed to be inheriting from SB classes, much less introduce virtual-ness to them (Greg can go in detail about the reasons, the tl;dr is that it has the potential to be ABI-breaking)

Oct 13 2015, 9:44 AM
granata.enrico added a comment to D13657: [lldb] char summary provider.

Currently I don't think SBTypeSummary allows for defining formatters backed by a CXXFunctionSummaryFormat
It would, however, be a great addition to our API. Is it a change you're interested in working on?

Oct 13 2015, 9:16 AM

Oct 12 2015

granata.enrico accepted D13682: [libstdc++ data-formatters] Remove size limits..
Oct 12 2015, 5:00 PM
granata.enrico added a comment to D13678: [libstdc++ data-formatters] Remove size limits and loop detector..

Removing the size limit would be acceptable, yes

Oct 12 2015, 4:08 PM
granata.enrico added a comment to D13678: [libstdc++ data-formatters] Remove size limits and loop detector..

Possibility number 3 (and the true reason why the check is there): if you stop at a place where the variable is not fully initialized/being torn down, and as a result, something is pointing back inside the list. For a list traversal, that is a deadly outcome.

Oct 12 2015, 3:26 PM
granata.enrico added a comment to D13678: [libstdc++ data-formatters] Remove size limits and loop detector..

Why are you removing the loop detection?

Oct 12 2015, 3:10 PM
granata.enrico added a comment to D13657: [lldb] char summary provider.

The consistency argument is not entirely unfair.

Oct 12 2015, 12:57 PM
granata.enrico requested changes to D13657: [lldb] char summary provider.

Truth be told, I find this notation (numeric value + printable character) to be heavy and somewhat redundant

Oct 12 2015, 10:34 AM

Oct 2 2015

granata.enrico added a comment to D13058: LLDB-MI: Bug when evaluating strings containing characters from non-ascii range.

I Thought I had marked it as good to go.
My bad if I have not.

Oct 2 2015, 1:15 PM
granata.enrico accepted D13058: LLDB-MI: Bug when evaluating strings containing characters from non-ascii range.

I am not deeply involved in MI internals, so I am going to assume you ran the test suite, and that you actually verified that types without summaries still work

Oct 2 2015, 10:32 AM

Oct 1 2015

granata.enrico requested changes to D13058: LLDB-MI: Bug when evaluating strings containing characters from non-ascii range.

Sorry, I didn't realize you were still waiting on me to land this patch.

Oct 1 2015, 2:40 PM

Sep 23 2015

granata.enrico added a comment to D12404: Testcase and fix for bug 24074.

I reverted this in revision 248421 because it was causing breakages in the test suite.

Sep 23 2015, 12:36 PM

Sep 22 2015

granata.enrico accepted D13084: Fix covered-switch-default warning in FormatManager..

LGTM

Sep 22 2015, 7:32 PM
granata.enrico added a comment to D13058: LLDB-MI: Bug when evaluating strings containing characters from non-ascii range.

My suggestion would be to add the DoesPrintValue() logic to SBTypeSummary. I can't recall if it's there already - but if not, it would be a fine thing to add. Then the MI could use SBValue and SBTypeSummary to make that determination as it sees fit.

Sep 22 2015, 11:57 AM
granata.enrico requested changes to D13058: LLDB-MI: Bug when evaluating strings containing characters from non-ascii range.

Is there a reason to explicitly add an API to get the concatenation of value and summary?

Sep 22 2015, 11:16 AM
granata.enrico accepted D13053: Fix evaluation of unicode character array types (char16_t[] and char32_t[]).

Only thing I would suggest is using LLDB_INVALID_ADDRESS instead of 0 in GetArrayAddressOrPointerValue()

Sep 22 2015, 10:33 AM

Sep 17 2015

granata.enrico accepted D12930: DataFormatters: Rename clang_type to compiler_type..

Fine by me

Sep 17 2015, 10:25 AM
granata.enrico accepted D12929: Remove unused includes from clang in DataFormatters..

I am assuming you built this successfully.

Sep 17 2015, 10:25 AM

Aug 17 2015

granata.enrico accepted D12092: [ValueObjectSynthetic and ValueObjectDynamicValue] Override GetDeclaration.

Assuming it passes the test suite, LGTM

Aug 17 2015, 6:01 PM
granata.enrico added a comment to D12092: [ValueObjectSynthetic and ValueObjectDynamicValue] Override GetDeclaration.

That looks reasonable

Aug 17 2015, 4:05 PM

Jul 27 2015

granata.enrico added a comment to D11498: Print reference values on one line..

Can you please try using revision 243301 or later?

Jul 27 2015, 11:37 AM

Jul 24 2015

granata.enrico requested changes to D11498: Print reference values on one line..
Jul 24 2015, 3:43 PM
granata.enrico added a reviewer for D11498: Print reference values on one line.: granata.enrico.
Jul 24 2015, 3:41 PM
granata.enrico added a comment to D11498: Print reference values on one line..

I am assuming that your intent is:

Jul 24 2015, 3:41 PM