Page MenuHomePhabricator

Fix layering issue by moving AliasScopeNode from ScopedNoAliasAA.h to Metadata.h
AbandonedPublic

Authored by modimo on Dec 3 2020, 11:02 AM.

Details

Reviewers
MaskRay
Summary

@MaskRay pointed out that having Metadata.h include ScopedNoAliasAA.h introduces a layering issue. The fix is
to move the declaration of AliasScopeNode to Metadata.h which is already included by ScopedNoAliasAA.cpp and remove Metadata.h
including ScopedNoAliasAA.h

Diff Detail

Unit TestsFailed

TimeTest
490 msx64 debian > MemProfiler-x86_64-linux.TestCases::test_malloc_load_store.c
Script: -- : 'RUN: at line 5'; /mnt/disks/ssd0/agent/llvm-project/build/./bin/clang --driver-mode=g++ -fmemory-profile -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer -fno-optimize-sibling-calls -gline-tables-only -m64 -O0 /mnt/disks/ssd0/agent/llvm-project/compiler-rt/test/memprof/TestCases/test_malloc_load_store.c -o /mnt/disks/ssd0/agent/llvm-project/build/projects/compiler-rt/test/memprof/X86_64LinuxConfig/TestCases/Output/test_malloc_load_store.c.tmp