This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Use -fmodules-validate-system-headers in the test suite
AbandonedPublic

Authored by ldionne on Dec 3 2020, 9:14 AM.

Details

Reviewers
rsmith
Group Reviewers
Restricted Project
Summary

As discussed in https://reviews.llvm.org/D91311#2431363, this is the
correct fix for making sure that Clang invalidates the cache when system
headers change.

Diff Detail

Event Timeline

ldionne created this revision.Dec 3 2020, 9:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 3 2020, 9:14 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne requested review of this revision.Dec 3 2020, 9:14 AM

This doesn't seem to have fixed the issue, since one of the builds is failing with a pattern similar to what I described: https://buildkite.com/llvm-project/libcxx-ci/builds/641#3b5d04ef-40fa-4cb0-b22a-0b1e11c41b0f

While building module 'std' imported from <...>/llvm-project/libcxx-ci/libcxx/test/libcxx/modules/stds_include.sh.cpp:34:
In file included from <module-includes>:31:
In file included from <...>/llvm-project/libcxx-ci/libcxx/include/complex.h:28:
In file included from <...>/llvm-project/libcxx-ci/libcxx/include/ccomplex:20:
In file included from <...>/llvm-project/libcxx-ci/libcxx/include/complex:242:
In file included from <...>/llvm-project/libcxx-ci/libcxx/include/sstream:173:
In file included from <...>/llvm-project/libcxx-ci/libcxx/include/ostream:137:
In file included from <...>/llvm-project/libcxx-ci/libcxx/include/ios:215:
In file included from <...>/llvm-project/libcxx-ci/libcxx/include/__locale:15:
<...>/llvm-project/libcxx-ci/libcxx/include/string:961:5: error: unknown type name '_LIBCPP_DEPRECATED_IN_CXX20'
    _LIBCPP_DEPRECATED_IN_CXX20 _LIBCPP_INLINE_VISIBILITY
    ^
ldionne abandoned this revision.Jun 2 2021, 3:44 PM