[clang] [Headers] Use the corresponding _aligned_free or __mingw_aligned_free in _mm_free

[rnk]

lgtm

clang/lib/Headers/mm_malloc.h

42

This has been here since 2011, and somehow nobody complained that we didn't use the corresponding __mingw_aligned_free API...

[mstorsjo]

clang/lib/Headers/mm_malloc.h

42

Due to https://github.com/mingw-w64/mingw-w64/blob/master/mingw-w64-headers/crt/malloc.h#L72 (which is included implicitly from stdlib.h), it hasn't been used much at all- maybe only when using the older mingw.org headers. But I'm considering suggesting to change that bit in the mingw-w64 headers (it's a bit of a mess when used with gcc's mm_malloc.h).

For msvc based configs it would have been noticable though. But I don't know how much _mm_malloc really is used...

clang/lib/Headers/mm_malloc.h

_mm_malloc(size_t __size, size_t __align)
   if (__align == 1) {
     return malloc(__size);
   }
 
   if (!(__align & (__align - 1)) && __align < sizeof(void *))
     __align = sizeof(void *);
 
   void *__mallocedMemory;
 #if defined(__MINGW32__)
   __mallocedMemory = __mingw_aligned_malloc(__size, __align);
 #elif defined(_WIN32)
   __mallocedMemory = _aligned_malloc(__size, __align);
 #else
   if (posix_memalign(&__mallocedMemory, __align, __size))
     return 0;
 #endif
 
   return __mallocedMemory;
 }
 
 static __inline__ void __attribute__((__always_inline__, __nodebug__))
 _mm_free(void *__p)
 {
+#if defined(__MINGW32__)
+  __mingw_aligned_free(__p);
+#elif defined(_WIN32)
+  _aligned_free(__p);
+#else
   free(__p);
+#endif
 }
 #endif
 
 #endif /* __MM_MALLOC_H */