On some of the slow or heavily-loaded bots, this test was failing intermittently because the infinite_loop.py script might not emit anything to stdout before the 1 second timeout, so the "Command Output" line isn't present in the output. That output isn't really important to this test, we just care that the process is killed, so we can just remove that check line from the test.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Thanks for looking into this, Oliver! This seems sensible to me, but I think @delcypher should probably have the final say.
Comment Actions
Makes sense to me (I can verify the failure mode by adding a sleep inside infinite_loop.py before it prints anything - and that this change fixes the issue) and this seems to be causing ongoing pain, so let's get this committed & @delcypher can weigh in post-commit when they have a chance.