Page MenuHomePhabricator

[Lit] Fix flaky test on heavily loaded bots

Authored by ostannard on Dec 3 2020, 3:01 AM.



On some of the slow or heavily-loaded bots, this test was failing intermittently because the script might not emit anything to stdout before the 1 second timeout, so the "Command Output" line isn't present in the output. That output isn't really important to this test, we just care that the process is killed, so we can just remove that check line from the test.

Diff Detail

Event Timeline

ostannard created this revision.Dec 3 2020, 3:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 3 2020, 3:01 AM
ostannard requested review of this revision.Dec 3 2020, 3:01 AM
rovka added a comment.Dec 3 2020, 3:20 AM

Thanks for looking into this, Oliver! This seems sensible to me, but I think @delcypher should probably have the final say.

dblaikie accepted this revision.Dec 3 2020, 10:54 AM

Makes sense to me (I can verify the failure mode by adding a sleep inside before it prints anything - and that this change fixes the issue) and this seems to be causing ongoing pain, so let's get this committed & @delcypher can weigh in post-commit when they have a chance.

This revision is now accepted and ready to land.Dec 3 2020, 10:54 AM
delcypher accepted this revision.Dec 3 2020, 11:38 AM

LGTM. @ostannard Thanks for investigating!

This revision was automatically updated to reflect the committed changes.