Page MenuHomePhabricator

[msan] Use REAL macro when calling intercepted function
Needs RevisionPublic

Authored by tstellar on Dec 2 2020, 3:54 PM.

Details

Diff Detail

Event Timeline

tstellar created this revision.Dec 2 2020, 3:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 2 2020, 3:54 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
tstellar requested review of this revision.Dec 2 2020, 3:54 PM

This code needs to call the interceptor to unpoison the output buffer.

As an alternative, unpoison the buffer after the REAL call (just copy the chunk from the previous function).

What problem does this change solve?

This code needs to call the interceptor to unpoison the output buffer.

As an alternative, unpoison the buffer after the REAL call (just copy the chunk from the previous function).

What problem does this change solve?

It fixes a compile error introduced in D92521 where I attempt to change the name of the interceptor. I thought based on the comments that the REAL() macro was necessary, but sound like I was wrong. Maybe it would be best to look at D92521 first, because that is the main problem I'm trying to fix.

vitalybuka requested changes to this revision.Apr 26 2021, 6:33 PM

I guess it's not needed as D92521 after D93877

This revision now requires changes to proceed.Apr 26 2021, 6:33 PM