Page MenuHomePhabricator

[Msan] Fix the getline.cc test to pass on FreeBSD
ClosedPublic

Authored by kutuzov.viktor.84 on Apr 24 2015, 5:37 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

kutuzov.viktor.84 retitled this revision from to [Msan] Fix the getline.cc test to pass on FreeBSD.
kutuzov.viktor.84 updated this object.
kutuzov.viktor.84 edited the test plan for this revision. (Show Details)
kutuzov.viktor.84 added a subscriber: Unknown Object (MLST).
eugenis edited edge metadata.Apr 24 2015, 7:45 AM

Why do you need this change in getdelim interceptors?

lib/sanitizer_common/sanitizer_common_interceptors.inc
3910 ↗(On Diff #24382)

Why do you need ... ?

kutuzov.viktor.84 edited edge metadata.

Updated to eliminate the ellipsis parameter.

Why do you need this change in getdelim interceptors?

There's no __getdelim() on FreeBSD so we shouldn't try to call REAL(__getdelim)() there and I'm not sure calling getdelim() from within the __getdelim() interceptor will work on all platforms.

eugenis accepted this revision.Apr 27 2015, 7:31 AM
eugenis edited edge metadata.

Thanks for the explanation.
LGTM.
Do you want to disable the __getdelim interceptor on FreeBSD, or just leave it there?

This revision is now accepted and ready to land.Apr 27 2015, 7:31 AM

Thanks Eugeniy. The plan is to disable non-FreeBSD interceptors with another series of commits, unless there's some urgency about it.

Sounds like a good plan.

This revision was automatically updated to reflect the committed changes.