Page MenuHomePhabricator

[hip] Fix host object creation from fatbin
ClosedPublic

Authored by hliao on Dec 1 2020, 12:05 PM.

Details

Summary
  • __hip_fatbin should a symbol in .hip_fatbin section.

Diff Detail

Event Timeline

hliao created this revision.Dec 1 2020, 12:05 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 1 2020, 12:05 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
hliao requested review of this revision.Dec 1 2020, 12:05 PM
hliao added a comment.Dec 1 2020, 12:07 PM

Even there's no functionality change, the original one breaks the kernel extraction script, which is designed to find the .hip_fatbin section. That internal tool is still required to extract kernels from objects generated from RDC linking.

ashi1 added a comment.EditedDec 1 2020, 12:33 PM

Looks good to me.

ashi1 accepted this revision.Dec 2 2020, 7:17 AM
This revision is now accepted and ready to land.Dec 2 2020, 7:17 AM
yaxunl accepted this revision.Dec 2 2020, 7:21 AM
This revision was automatically updated to reflect the committed changes.