This is an archive of the discontinued LLVM Phabricator instance.

lld/ELF: Make three rarely-used flags work with --reproduce
ClosedPublic

Authored by thakis on Nov 30 2020, 4:56 PM.

Details

Summary

All three use readFile() for their argument so their argument file is
already copied to the tar, but we weren't rewriting the argument to
point to the path used in the tar file.

No test because the change is trivial (several other flags in
createResponseFile() also aren't tested, likely for the same reason.)

Diff Detail

Event Timeline

thakis created this revision.Nov 30 2020, 4:56 PM
thakis requested review of this revision.Nov 30 2020, 4:56 PM
MaskRay accepted this revision.Nov 30 2020, 11:00 PM

LGTM.

This revision is now accepted and ready to land.Nov 30 2020, 11:00 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptDec 1 2020, 6:21 AM