This is an archive of the discontinued LLVM Phabricator instance.

[libc++] [docs] Update and move NOTES.txt to docs/Contributing.rst.
ClosedPublic

Authored by curdeius on Nov 30 2020, 1:02 AM.

Details

Summary

Also, add notes about exporting ABI symbols.
Later, we can add notes about using git-clang-format before sending a patch for review.

Diff Detail

Event Timeline

curdeius created this revision.Nov 30 2020, 1:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 30 2020, 1:02 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
curdeius requested review of this revision.Nov 30 2020, 1:02 AM

This patch updates the notes about how to contribute to libc++ adding some missing elements (found in https://reviews.llvm.org/D92240).

ldionne requested changes to this revision.Dec 1 2020, 2:32 PM

Thanks, only a minor comment. Let's clean up NOTES.txt.

libcxx/NOTES.TXT
1

I think it's fine to just delete this file.

This revision now requires changes to proceed.Dec 1 2020, 2:32 PM
ldionne accepted this revision.Dec 1 2020, 3:06 PM

Actually, feel free to commit after removing NOTES.txt.

This revision is now accepted and ready to land.Dec 1 2020, 3:06 PM