[LLDB/Python] Fix segfault on Python scripted breakpoints

[tammela]

Summary

The code that calls into the ScriptInterpreter was not considering the
case that it receives a Lua interpreter.

[JDevlieghere]

It appears there are many similar calls in this file, can you update those as well?

[labath]

In D92249#2421639, @JDevlieghere wrote:

It appears there are many similar calls in this file, can you update those as well?

If there are many of these calls, adding a static helper function for this purpose might be a good idea as well...

[tammela]

In D92249#2422205, @labath wrote:

In D92249#2421639, @JDevlieghere wrote:

It appears there are many similar calls in this file, can you update those as well?

If there are many of these calls, adding a static helper function for this purpose might be a good idea as well...

Yes, it looks like the same 3-line routine is being replicated across multiple functions. I will clean it up.

[tammela]

Addressing comments

[JDevlieghere]

Thanks! LGTM

lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp

 //===-- ScriptInterpreterPython.cpp ---------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 #include "lldb/Host/Config.h"
+#include "lldb/lldb-enumerations.h"
 
 #if LLDB_ENABLE_PYTHON
 
 // LLDB Python header must be included first
 #include "lldb-python.h"
 
 #include "PythonDataObjects.h"
 #include "PythonReadline.h"
bool ScriptInterpreterPythonImpl::BreakpointCallbackFunction(
 
   ExecutionContext exe_ctx(context->exe_ctx_ref);
   Target *target = exe_ctx.GetTargetPtr();
 
   if (!target)
     return true;
 
   Debugger &debugger = target->GetDebugger();
-  ScriptInterpreter *script_interpreter = debugger.GetScriptInterpreter();
+  ScriptInterpreter *script_interpreter =
+      debugger.GetScriptInterpreter(true, eScriptLanguagePython);
   ScriptInterpreterPythonImpl *python_interpreter =
       (ScriptInterpreterPythonImpl *)script_interpreter;
 
   if (!script_interpreter)
     return true;
 
   if (python_function_name && python_function_name[0]) {
     const StackFrameSP stop_frame_sp(exe_ctx.GetFrameSP());

lldb/test/Shell/ScriptInterpreter/Python/scripted_breakpoint_lua.test

+# REQUIRES: python
+# UNSUPPORTED: lldb-repro
+#
+# RUN: cat %s | %lldb --script-language lua 2>&1 | FileCheck %s
+b main
+breakpoint command add -s python -o 'print(frame); return False'
+run
+# CHECK: frame #0