Page MenuHomePhabricator

tammela (Pedro Tammela)
User

Projects

User does not belong to any projects.

User Details

User Since
May 3 2020, 7:47 AM (63 w, 6 d)

Recent Activity

Wed, Jul 7

tammela committed rGe81ba283131c: [lldb/lua] Add scripted watchpoints for Lua (authored by Siger Yang <sigeryeung@gmail.com>).
[lldb/lua] Add scripted watchpoints for Lua
Wed, Jul 7, 10:51 AM
tammela closed D105034: [lldb/lua] Add scripted watchpoints for Lua.
Wed, Jul 7, 10:51 AM · Restricted Project

Sun, Jul 4

tammela accepted D105034: [lldb/lua] Add scripted watchpoints for Lua.

I tested locally and it seems fine!

Sun, Jul 4, 4:26 PM · Restricted Project

Tue, Jun 29

tammela added a comment to D105034: [lldb/lua] Add scripted watchpoints for Lua.

Clang format complained a bit, please fix those.

Tue, Jun 29, 5:14 PM · Restricted Project

Jun 17 2021

tammela added a reviewer for D104281: [lldb][docs] Add reference docs for Lua scripting: tammela.
Jun 17 2021, 10:50 AM · Restricted Project

Jan 25 2021

tammela committed rG532e4203c5be: [lldb/Lua] add support for Lua function breakpoint (authored by tammela).
[lldb/Lua] add support for Lua function breakpoint
Jan 25 2021, 3:41 PM
tammela closed D93649: [lldb/Lua] add support for Lua function breakpoint.
Jan 25 2021, 3:41 PM · Restricted Project

Jan 23 2021

tammela added a comment to D93649: [lldb/Lua] add support for Lua function breakpoint.

@JDevlieghere Addressed all your comments.

Jan 23 2021, 10:49 AM · Restricted Project
tammela updated the diff for D93649: [lldb/Lua] add support for Lua function breakpoint.

Rebasing and unwrapping the SBStructuredData test case

Jan 23 2021, 10:47 AM · Restricted Project
tammela committed rG2bbc762b8ff8: [lldb/Lua] add 'Lua' before naming versions (authored by tammela).
[lldb/Lua] add 'Lua' before naming versions
Jan 23 2021, 7:22 AM
tammela committed rG5997e8987f68: [lldb/Lua] add initial Lua typemaps (authored by tammela).
[lldb/Lua] add initial Lua typemaps
Jan 23 2021, 7:19 AM
tammela closed D94937: [lldb/Lua] add initial Lua typemaps.
Jan 23 2021, 7:18 AM · Restricted Project

Jan 21 2021

tammela updated the diff for D94937: [lldb/Lua] add initial Lua typemaps.

Typos

Jan 21 2021, 1:20 PM · Restricted Project
tammela retitled D94937: [lldb/Lua] add initial Lua typemaps from [lldb] change SBStructuredData GetStringValue signature to [lldb/Lua] add initial Lua typemaps.
Jan 21 2021, 1:18 PM · Restricted Project
tammela updated the diff for D94937: [lldb/Lua] add initial Lua typemaps.

Addressing comments

Jan 21 2021, 1:16 PM · Restricted Project

Jan 20 2021

tammela added a comment to D94937: [lldb/Lua] add initial Lua typemaps.

I replied before I actually tried to understand what your'e trying to achieve, and it's still not entirely clear to me. I think what you need is something similar like python-typemaps.swig which helps swig understand char** types and such.

For context, originally SWIG wasn't great at handling std::strings (which has since been fixed) and the designers of the SB API were worried about the ABI stability of the std::string class. None of these are concerns anymore today, but the ABI being stable means we're stuck with it for now. If we ever do an SB API v2, this is definitely one of the things we'd fix, but currently there are no plans for that.

Jan 20 2021, 5:27 PM · Restricted Project

Jan 19 2021

tammela added a comment to D94937: [lldb/Lua] add initial Lua typemaps.

We guarantee that the SB API is ABI stable so you cannot change the signature of existing functions. Would an overload do the trick?

Jan 19 2021, 9:51 AM · Restricted Project

Jan 18 2021

tammela added a comment to D94937: [lldb/Lua] add initial Lua typemaps.

We guarantee that the SB API is ABI stable so you cannot change the signature of existing functions. Would an overload do the trick?

Jan 18 2021, 4:46 PM · Restricted Project
tammela updated the diff for D94937: [lldb/Lua] add initial Lua typemaps.

Removing spurious line

Jan 18 2021, 4:43 PM · Restricted Project
tammela requested review of D94937: [lldb/Lua] add initial Lua typemaps.
Jan 18 2021, 4:38 PM · Restricted Project
tammela added inline comments to D93649: [lldb/Lua] add support for Lua function breakpoint.
Jan 18 2021, 11:20 AM · Restricted Project
tammela updated the diff for D93649: [lldb/Lua] add support for Lua function breakpoint.

Addressing comment

Jan 18 2021, 11:19 AM · Restricted Project

Jan 9 2021

tammela added inline comments to D93649: [lldb/Lua] add support for Lua function breakpoint.
Jan 9 2021, 10:44 AM · Restricted Project

Jan 6 2021

tammela committed rGd853bd7a4e86: [lldb/Lua] add support for multiline scripted breakpoints (authored by tammela).
[lldb/Lua] add support for multiline scripted breakpoints
Jan 6 2021, 4:32 PM
tammela closed D93481: [lldb/Lua] add support for multiline scripted breakpoints.
Jan 6 2021, 4:32 PM · Restricted Project

Jan 4 2021

tammela added a comment to D93649: [lldb/Lua] add support for Lua function breakpoint.

ping

Jan 4 2021, 5:45 AM · Restricted Project
tammela added a comment to D93481: [lldb/Lua] add support for multiline scripted breakpoints.

ping

Jan 4 2021, 5:45 AM · Restricted Project

Dec 28 2020

tammela added inline comments to D93481: [lldb/Lua] add support for multiline scripted breakpoints.
Dec 28 2020, 10:08 AM · Restricted Project
tammela updated the diff for D93481: [lldb/Lua] add support for multiline scripted breakpoints.

Addressing comments

Dec 28 2020, 9:49 AM · Restricted Project

Dec 22 2020

tammela added inline comments to D93481: [lldb/Lua] add support for multiline scripted breakpoints.
Dec 22 2020, 7:29 AM · Restricted Project

Dec 21 2020

tammela added reviewers for D93649: [lldb/Lua] add support for Lua function breakpoint: labath, JDevlieghere.
Dec 21 2020, 10:14 AM · Restricted Project
tammela requested review of D93649: [lldb/Lua] add support for Lua function breakpoint.
Dec 21 2020, 10:13 AM · Restricted Project

Dec 19 2020

tammela added inline comments to D93481: [lldb/Lua] add support for multiline scripted breakpoints.
Dec 19 2020, 11:10 AM · Restricted Project
tammela updated the diff for D93481: [lldb/Lua] add support for multiline scripted breakpoints.

Addressing comments

Dec 19 2020, 11:10 AM · Restricted Project

Dec 17 2020

tammela added reviewers for D93481: [lldb/Lua] add support for multiline scripted breakpoints: JDevlieghere, labath.
Dec 17 2020, 11:51 AM · Restricted Project
tammela requested review of D93481: [lldb/Lua] add support for multiline scripted breakpoints.
Dec 17 2020, 11:50 AM · Restricted Project

Dec 7 2020

tammela committed rG280ae10774ab: [LLDB] fix error message for one-line breakpoint scripts (authored by tammela).
[LLDB] fix error message for one-line breakpoint scripts
Dec 7 2020, 3:23 AM
tammela closed D92729: [LLDB] fix error message for one-line breakpoint scripts.
Dec 7 2020, 3:23 AM · Restricted Project

Dec 6 2020

tammela added reviewers for D92729: [LLDB] fix error message for one-line breakpoint scripts: labath, JDevlieghere.
Dec 6 2020, 6:35 AM · Restricted Project
tammela requested review of D92729: [LLDB] fix error message for one-line breakpoint scripts.
Dec 6 2020, 6:35 AM · Restricted Project

Dec 2 2020

tammela committed rGd055e3a0eb4e: [LLDB/Python] Fix segfault on Python scripted entrypoints (authored by tammela).
[LLDB/Python] Fix segfault on Python scripted entrypoints
Dec 2 2020, 3:26 AM
tammela closed D92249: [LLDB/Python] Fix segfault on Python scripted breakpoints.
Dec 2 2020, 3:25 AM · Restricted Project

Dec 1 2020

tammela updated the diff for D92249: [LLDB/Python] Fix segfault on Python scripted breakpoints.

Addressing comments

Dec 1 2020, 3:38 AM · Restricted Project

Nov 30 2020

tammela committed rGa0d7406ae800: [LLDB/Lua] add support for one-liner breakpoint callback (authored by tammela).
[LLDB/Lua] add support for one-liner breakpoint callback
Nov 30 2020, 6:12 AM
tammela closed D91508: [LLDB/Lua] add support for one-liner breakpoint callback.
Nov 30 2020, 6:12 AM · Restricted Project
tammela updated the diff for D91508: [LLDB/Lua] add support for one-liner breakpoint callback.

Addressing comments

Nov 30 2020, 4:16 AM · Restricted Project
tammela added a comment to D92249: [LLDB/Python] Fix segfault on Python scripted breakpoints.

It appears there are many similar calls in this file, can you update those as well?

If there are many of these calls, adding a static helper function for this purpose might be a good idea as well...

Nov 30 2020, 3:56 AM · Restricted Project

Nov 27 2020

tammela added a reviewer for D92249: [LLDB/Python] Fix segfault on Python scripted breakpoints: JDevlieghere.
Nov 27 2020, 3:13 PM · Restricted Project
tammela requested review of D92249: [LLDB/Python] Fix segfault on Python scripted breakpoints.
Nov 27 2020, 3:12 PM · Restricted Project
tammela added inline comments to D91508: [LLDB/Lua] add support for one-liner breakpoint callback.
Nov 27 2020, 5:52 AM · Restricted Project
tammela updated the diff for D91508: [LLDB/Lua] add support for one-liner breakpoint callback.

Addressing review comments

Nov 27 2020, 5:51 AM · Restricted Project

Nov 24 2020

tammela updated the diff for D91508: [LLDB/Lua] add support for one-liner breakpoint callback.

Remove unnecessary wrappers/checks

Nov 24 2020, 1:15 PM · Restricted Project
tammela added a comment to D91508: [LLDB/Lua] add support for one-liner breakpoint callback.

Right. That's why I'd like to have good wrappers, which make it easy to do the right thing, and hard to do the wrong one.

I don't think we're quite there yet, but before I comment on the API, I want to understand one other thing.

I am puzzled by all the wrapping that's happening inside the PushSBClass functions. What is that protecting us from? I would hope that pushing a swig wrapper on the stack is a safe operation...

I thought that too, but internally it's a naked call to lua_newuserdata() which might throw in case of a memory error.

So, IIUC, this can only fail if we are running out of memory? If that's the case, then I would remove these checks, as (for better or worse) llvm is not robust against memory allocation errors, and they add a fair amount of cruft to the code.

Fair enough. Will remove those.
Since this seems to be a fact of life for LLVM, perhaps wrapping potential memory errors turns out to be just bloat. If that's the case, then the wrapping in PushSBClass is not needed and the abort() call that Lua does is honest.

Nov 24 2020, 6:59 AM · Restricted Project

Nov 23 2020

tammela added a comment to D91508: [LLDB/Lua] add support for one-liner breakpoint callback.

I'm not sure what you mean by that. Can you elaborate?

Nov 23 2020, 2:47 PM · Restricted Project
tammela updated the diff for D91508: [LLDB/Lua] add support for one-liner breakpoint callback.

Redesign of the API

Nov 23 2020, 2:37 PM · Restricted Project

Nov 18 2020

tammela added inline comments to D91508: [LLDB/Lua] add support for one-liner breakpoint callback.
Nov 18 2020, 12:16 PM · Restricted Project
tammela planned changes to D91508: [LLDB/Lua] add support for one-liner breakpoint callback.
Nov 18 2020, 11:41 AM · Restricted Project

Nov 17 2020

tammela added a comment to D91508: [LLDB/Lua] add support for one-liner breakpoint callback.

@JDevlieghere

When writing this patch I noticed that there is no mechanism in-place to remove the Python/Lua function when the breakpoint is removed or when the callback function is replaced.
The class that sets the callback provides ClearCallback() but it never calls into the ScriptInterpreter to clean up.
Although the real world impact is not that big, it's crucial for a small memory footprint. Any thoughts on this?

I see, it looks like we just clean up the LLDB side but never tell the runtimes about it. What exactly are we leaking in that case? Do you think it's worth it to wire that up?

Nov 17 2020, 12:20 PM · Restricted Project
tammela added inline comments to D91508: [LLDB/Lua] add support for one-liner breakpoint callback.
Nov 17 2020, 12:15 PM · Restricted Project
tammela updated the diff for D91508: [LLDB/Lua] add support for one-liner breakpoint callback.

Adressing comments

Nov 17 2020, 12:15 PM · Restricted Project
tammela added inline comments to D91508: [LLDB/Lua] add support for one-liner breakpoint callback.
Nov 17 2020, 1:30 AM · Restricted Project

Nov 16 2020

tammela updated the diff for D91508: [LLDB/Lua] add support for one-liner breakpoint callback.

Clean up includes

Nov 16 2020, 1:11 AM · Restricted Project

Nov 15 2020

tammela added a comment to D91508: [LLDB/Lua] add support for one-liner breakpoint callback.

When writing this patch I noticed that there is no mechanism in-place to remove the Python/Lua function when the breakpoint is removed or when the callback function is replaced.
The class that sets the callback provides ClearCallback() but it never calls into the ScriptInterpreter to clean up.
Although the real world impact is not that big, it's crucial for a small memory footprint. Any thoughts on this?

Nov 15 2020, 1:09 PM · Restricted Project
tammela added a reviewer for D91508: [LLDB/Lua] add support for one-liner breakpoint callback: JDevlieghere.
Nov 15 2020, 1:02 PM · Restricted Project
tammela requested review of D91508: [LLDB/Lua] add support for one-liner breakpoint callback.
Nov 15 2020, 1:01 PM · Restricted Project

Nov 8 2020

tammela committed rG5e8ecff0d806: [Reg2Mem] add support for the new pass manager (authored by tammela).
[Reg2Mem] add support for the new pass manager
Nov 8 2020, 3:15 AM
tammela closed D91005: [Reg2Mem] add support for the new pass manager.
Nov 8 2020, 3:15 AM · Restricted Project

Nov 7 2020

tammela updated the diff for D91005: [Reg2Mem] add support for the new pass manager.

Add test case, fix line column

Nov 7 2020, 10:50 AM · Restricted Project
tammela added a reviewer for D91005: [Reg2Mem] add support for the new pass manager: dmgreen.
Nov 7 2020, 9:30 AM · Restricted Project
tammela requested review of D91005: [Reg2Mem] add support for the new pass manager.
Nov 7 2020, 9:29 AM · Restricted Project

Nov 5 2020

tammela committed rGca17571051d4: [LLDB-lua] modify Lua's 'print' to respect 'io.stdout' (authored by tammela).
[LLDB-lua] modify Lua's 'print' to respect 'io.stdout'
Nov 5 2020, 1:32 PM
tammela closed D90787: [LLDB-lua] modify Lua's 'print' to respect 'io.stdout'.
Nov 5 2020, 1:32 PM · Restricted Project
tammela updated the diff for D90787: [LLDB-lua] modify Lua's 'print' to respect 'io.stdout'.

Add test case

Nov 5 2020, 4:59 AM · Restricted Project

Nov 4 2020

tammela added a reviewer for D90787: [LLDB-lua] modify Lua's 'print' to respect 'io.stdout': JDevlieghere.
Nov 4 2020, 12:51 PM · Restricted Project
tammela requested review of D90787: [LLDB-lua] modify Lua's 'print' to respect 'io.stdout'.
Nov 4 2020, 12:50 PM · Restricted Project

Nov 3 2020

tammela committed rG4b9fa3b705c8: [LLDB][NFC] treat Lua error codes in a more explicit manner (authored by tammela).
[LLDB][NFC] treat Lua error codes in a more explicit manner
Nov 3 2020, 1:40 AM
tammela closed D90556: [LLDB][NFC] treat Lua error codes in a more explicit manner.
Nov 3 2020, 1:40 AM · Restricted Project

Nov 2 2020

tammela committed rG4d7d6f276c6d: [LLDB/Lua] call lua_close() on Lua dtor (authored by tammela).
[LLDB/Lua] call lua_close() on Lua dtor
Nov 2 2020, 8:54 AM
tammela closed D90557: [LLDB/Lua] call lua_close() on Lua dtor.
Nov 2 2020, 8:54 AM · Restricted Project

Nov 1 2020

tammela added a reviewer for D90557: [LLDB/Lua] call lua_close() on Lua dtor: JDevlieghere.
Nov 1 2020, 10:14 AM · Restricted Project
tammela requested review of D90557: [LLDB/Lua] call lua_close() on Lua dtor.
Nov 1 2020, 10:14 AM · Restricted Project
tammela added a reviewer for D90556: [LLDB][NFC] treat Lua error codes in a more explicit manner: JDevlieghere.
Nov 1 2020, 8:27 AM · Restricted Project
tammela requested review of D90556: [LLDB][NFC] treat Lua error codes in a more explicit manner.
Nov 1 2020, 8:26 AM · Restricted Project

Oct 25 2020

tammela requested review of D90122: [NFC][Reg2Mem] modernize loops iterators.
Oct 25 2020, 9:47 AM · Restricted Project

Oct 24 2020

tammela retitled D90069: [NFC}[LoopSimplify] modernize for loops over LoopInfo from [LoopSimplify] modernize for loops over LoopInfo to [NFC}[LoopSimplify] modernize for loops over LoopInfo.
Oct 24 2020, 5:14 AM · Restricted Project

Oct 23 2020

tammela requested review of D90069: [NFC}[LoopSimplify] modernize for loops over LoopInfo.
Oct 23 2020, 12:26 PM · Restricted Project

Oct 17 2020

tammela added a comment to D89603: [NFC] fix some typos in LoopUnrollPass.

@dmgreen Thank you. I don't have commit access, could you please carry it out to upstream?

Oct 17 2020, 2:45 AM · Restricted Project

Oct 16 2020

tammela requested review of D89603: [NFC] fix some typos in LoopUnrollPass.
Oct 16 2020, 4:59 PM · Restricted Project