[libc++] Remove sysctl-based implementation of thread::hardware_concurrency()

[ldionne]

Summary

Using sysctl requires including headers that are considered internal on
Linux, like <sys/sysctl.h> & friends. Instead, sysconf is defined by POSIX
(and we have a fallback for Windows), so all the systems we support should
be happy with just sysconf.

[MaskRay]

I confirm that sysconf(_SC_NPROCESSORS_ONLN) works on musl. Thanks

[ldionne]

In D92135#2417227, @MaskRay wrote:

I confirm that sysconf(_SC_NPROCESSORS_ONLN) works on musl. Thanks

Thanks!

libcxx/src/thread.cpp

 #ifndef _LIBCPP_HAS_NO_THREADS
 
 #include "thread"
 #include "exception"
 #include "vector"
 #include "future"
 #include "limits"
 
-#if __has_include(<sys/types.h>)
-# include <sys/types.h>
-#endif
-
-#if __has_include(<sys/param.h>)
-# include <sys/param.h>
-#endif
-
-#if __has_include(<sys/sysctl.h>)
-# include <sys/sysctl.h>
-#endif
-
 #if __has_include(<unistd.h>)
-# include <unistd.h>
+# include <unistd.h> // for sysconf
 #endif
 
 #if defined(__NetBSD__)
 #pragma weak pthread_create // Do not create libpthread dependency
 #endif
 
 #if defined(_LIBCPP_WIN32API)
 #include <windows.h>
thread::detach()
 
     if (ec)
         __throw_system_error(ec, "thread::detach failed");
 }
 
 unsigned
 thread::hardware_concurrency() _NOEXCEPT
 {
-#if defined(CTL_HW) && defined(HW_NCPU)
-    unsigned n;
-    int mib[2] = {CTL_HW, HW_NCPU};
-    std::size_t s = sizeof(n);
-    sysctl(mib, 2, &n, &s, 0, 0);
-    return n;
-#elif defined(_SC_NPROCESSORS_ONLN)
+#if defined(_SC_NPROCESSORS_ONLN)
     long result = sysconf(_SC_NPROCESSORS_ONLN);
     // sysconf returns -1 if the name is invalid, the option does not exist or
     // does not have a definite limit.
     // if sysconf returns some other negative number, we have no idea
     // what is going on. Default to something safe.
     if (result < 0)
         return 0;
     return static_cast<unsigned>(result);