Since there is no ROCm Device Library support for
long double, demote them to double, and use the fp64
math functions.
Details
Details
- Reviewers
yaxunl tra - Commits
- rGba2612ce01ea: [HIP] cmath demote long double args to double
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
There are applications calling functions such as fmod(long double x, long double y), but this produces a "call is ambiguous" error.
Comment Actions
LGTM in general. Will defer to Sam as it's HIP.
Nit:
long double, promote them to double, and use the fp64
I'd say long double -> double qualifies as a demotion.