This is an archive of the discontinued LLVM Phabricator instance.

[hwasan] Fix tests when vm.overcommit_memory=1.
ClosedPublic

Authored by eugenis on Nov 23 2020, 4:05 PM.

Reviewers

pcc
hctim

Commits

Summary

Remove an invalid check from sizes.cpp that only passes when overcommit is disabled.

Fixes PR48274.

Herald added a subscriber: Restricted Project. · View Herald Transcript

eugenis requested review of this revision.Nov 23 2020, 4:05 PM

LGTM

This revision is now accepted and ready to land.Nov 23 2020, 4:18 PM

This revision was landed with ongoing or failed builds.Nov 23 2020, 4:21 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

compiler-rt/

test/

hwasan/

TestCases/

2 lines

Show First 20 Lines • Show All 43 Lines • ▼ Show 20 Lines	int main(int argc, char **argv) {
static const size_t kChunkHeaderSize = 16;		static const size_t kChunkHeaderSize = 16;

size_t MallocSize = test_size_max ? std::numeric_limits<size_t>::max()		size_t MallocSize = test_size_max ? std::numeric_limits<size_t>::max()
: (kMaxAllowedMallocSize + 1);		: (kMaxAllowedMallocSize + 1);

if (!untag_strcmp(argv[1], "malloc")) {		if (!untag_strcmp(argv[1], "malloc")) {
void *p = malloc(MallocSize);		void *p = malloc(MallocSize);
assert(!p);		assert(!p);
p = malloc(kMaxAllowedMallocSize - kChunkHeaderSize);
assert(!p);
} else if (!untag_strcmp(argv[1], "calloc")) {		} else if (!untag_strcmp(argv[1], "calloc")) {
// Trigger an overflow in calloc.		// Trigger an overflow in calloc.
size_t size = std::numeric_limits<size_t>::max();		size_t size = std::numeric_limits<size_t>::max();
void *p = calloc((size / 0x1000) + 1, 0x1000);		void *p = calloc((size / 0x1000) + 1, 0x1000);
assert(!p);		assert(!p);
} else if (!untag_strcmp(argv[1], "reallocarray")) {		} else if (!untag_strcmp(argv[1], "reallocarray")) {
// Trigger an overflow in reallocarray.		// Trigger an overflow in reallocarray.
size_t size = std::numeric_limits<size_t>::max();		size_t size = std::numeric_limits<size_t>::max();
Show All 32 Lines