Page MenuHomePhabricator

[llvm-zorg] Exit early (skip tests) if builds failed
ClosedPublic

Authored by oontvoo on Nov 19 2020, 10:20 AM.

Details

Summary

This helps reducing the error log.
You don't have to scroll all the way up to see that the test failed because there was no libclang_rt.* files (due to compilation failure in build steps)

Diff Detail

Event Timeline

oontvoo created this revision.Nov 19 2020, 10:20 AM
oontvoo requested review of this revision.Nov 19 2020, 10:20 AM
oontvoo updated this revision to Diff 306465.Nov 19 2020, 10:22 AM

fixed typo

vitalybuka accepted this revision.Nov 19 2020, 3:40 PM

LGTM either way

zorg/buildbot/builders/sanitizers/buildbot_android_functions.sh
121–122

why not exit here?
I suspect probability that one platform build and another don't is almost 0

This revision is now accepted and ready to land.Nov 19 2020, 3:40 PM
oontvoo marked an inline comment as done.Nov 19 2020, 6:20 PM
oontvoo added inline comments.
zorg/buildbot/builders/sanitizers/buildbot_android_functions.sh
121–122

I think there is enough code behind platform-specific #if-defs that the chance of it breaking in one platform and not the others is not that low :-)

In fact, we've seen that just recently in the lsan patches, no? __aeabi_read_tp missing on arm but not the others

Thanks!

This revision was automatically updated to reflect the committed changes.
oontvoo marked an inline comment as done.