Page MenuHomePhabricator

Add support for FreeBSD arm live debugging
ClosedPublic

Authored by emaste on Apr 21 2015, 1:04 PM.

Details

Summary

Fix RegisterContextPOSIX_arm::GetReisterSet
The target trip should be 'arm' not 'aarch64'

Add sw brkpt insn to PlatformFreeBSD::GetSoftwareBreakpointTrapOpcode

Diff Detail

Repository
rL LLVM

Event Timeline

trixirt updated this revision to Diff 24159.Apr 21 2015, 1:04 PM
trixirt retitled this revision from to Add support for FreeBSD arm live debugging.
trixirt updated this object.
trixirt edited the test plan for this revision. (Show Details)
trixirt added reviewers: omjavaid, emaste.
trixirt set the repository for this revision to rL LLVM.
trixirt added a subscriber: Unknown Object (MLST).Apr 21 2015, 1:06 PM
omjavaid edited edge metadata.Apr 21 2015, 5:33 PM

Its easier to review full context diffs. Please generate it using (git diff -U999999 or svn diff --diff-cmd=diff -x -U999999)

source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp
347 ↗(On Diff #24159)

Please add case for arm in alphabetical order before ppc.

Also add a TODO to handle both (little/big endian) arm and thumb mode trap codes.

trixirt updated this revision to Diff 24867.May 3 2015, 10:35 AM
trixirt edited edge metadata.

Handle thumb breakpoints
Detect when in thumb code and silently disable breakpoints
FreeBSD does not support thumb breakpoints.
Define a reasonable breakpoint instruction to enable when thumb breakpoints are supported

trixirt edited the test plan for this revision. (Show Details)May 3 2015, 10:37 AM
emaste edited edge metadata.May 27 2015, 12:52 PM

Seems I didn't get any email notification from Phabricator for this :(
I will extract the thumb part and apply it.

source/Plugins/Process/POSIX/POSIXThread.cpp
179 ↗(On Diff #24867)

Whitespace issue?

emaste commandeered this revision.May 27 2015, 1:03 PM
emaste updated this revision to Diff 26627.
emaste edited reviewers, added: trixirt; removed: emaste.
emaste removed rL LLVM as the repository for this revision.

Extract thumb opcode stub from original change and sync whitespace etc. with PlatformLinux.cpp

trixirt edited edge metadata.May 28 2015, 6:02 AM

Thanks!

There is also a change to support core file reading, that I believe is
ready.
http://reviews.llvm.org/D9292

Tom

This revision was automatically updated to reflect the committed changes.