This is an archive of the discontinued LLVM Phabricator instance.

Differential D91686

[compiler-rt sanitizer] Use our own PTRACE_GETREGSET if it does not exist.
ClosedPublic

Authored by jeroen.dobbelaere on Nov 18 2020, 12:17 AM.

Details

Reviewers
morehouse
vitalybuka
Commits
rG8d33f08844a1: [compiler-rt sanitizer] Use our own PTRACE_GETREGSET if it does not exist.
Summary

On RH66 does not support 'PTRACE_GETREGSET'. This change makes this part of compiler-rt build again on older os-es

Diff Detail

Event Timeline

jeroen.dobbelaere created this revision.Nov 18 2020, 12:17 AM
Herald added a subscriber: dberris. · View Herald TranscriptNov 18 2020, 12:17 AM
jeroen.dobbelaere requested review of this revision.Nov 18 2020, 12:17 AM
jeroen.dobbelaere mentioned this in D87754: [Lsan] Use fp registers to search for pointers.Nov 18 2020, 12:19 AM
vitalybuka added inline comments.Nov 18 2020, 1:04 AM
compiler-rt/lib/sanitizer_common/sanitizer_stoptheworld_linux_libcdep.cpp
490–495

maybe something like this?

jeroen.dobbelaere updated this revision to Diff 309241.Dec 3 2020, 6:27 AM

Adapted to define PTRACE_GETREGSET ourselves if it is not available.

jeroen.dobbelaere marked an inline comment as done.Dec 3 2020, 6:27 AM
jeroen.dobbelaere retitled this revision from [compiler-rt sanitizer] Only use PTRACE_GETREGSET if it exists to [compiler-rt sanitizer] Use our own PTRACE_GETREGSET if it does not exist..Dec 3 2020, 6:30 AM
vitalybuka accepted this revision.Dec 9 2020, 12:29 AM
This revision is now accepted and ready to land.Dec 9 2020, 12:29 AM
Closed by commit rG8d33f08844a1: [compiler-rt sanitizer] Use our own PTRACE_GETREGSET if it does not exist. (authored by jeroen.dobbelaere, committed by vitalybuka). · Explain WhyDec 9 2020, 1:08 AM
This revision was automatically updated to reflect the committed changes.
vitalybuka added a commit: rG8d33f08844a1: [compiler-rt sanitizer] Use our own PTRACE_GETREGSET if it does not exist..
Herald added a project: Restricted Project. · View Herald TranscriptDec 9 2020, 1:08 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript

Revision Contents

PathSize
compiler-rt/
lib/
sanitizer_common/
3 lines

Diff 309241

compiler-rt/lib/sanitizer_common/sanitizer_stoptheworld_linux_libcdep.cpp

Show First 20 Lines • Show All 481 Lines • ▼ Show 20 Lines
typedef user_regs_struct regs_struct; typedef user_regs_struct regs_struct;
#if defined(__i386__) #if defined(__i386__)
#define REG_SP esp #define REG_SP esp
#else #else
#define REG_SP rsp #define REG_SP rsp
#endif #endif
#define ARCH_IOVEC_FOR_GETREGSET #define ARCH_IOVEC_FOR_GETREGSET
// Support ptrace extensions even when compiled without required kernel support // Support ptrace extensions even when compiled without required kernel support
#ifndef NT_X86_XSTATE #ifndef NT_X86_XSTATE
#define NT_X86_XSTATE 0x202 #define NT_X86_XSTATE 0x202
#endif #endif
#ifndef PTRACE_GETREGSET
#define PTRACE_GETREGSET 0x4204
#endif
vitalybukaUnsubmitted
Done
ReplyInline Actions

maybe something like this?

vitalybuka: maybe something like this?
// Compiler may use FP registers to store pointers. // Compiler may use FP registers to store pointers.
static constexpr uptr kExtraRegs[] = {NT_X86_XSTATE, NT_FPREGSET}; static constexpr uptr kExtraRegs[] = {NT_X86_XSTATE, NT_FPREGSET};
#elif defined(__powerpc__) || defined(__powerpc64__) #elif defined(__powerpc__) || defined(__powerpc64__)
typedef pt_regs regs_struct; typedef pt_regs regs_struct;
#define REG_SP gpr[PT_R1] #define REG_SP gpr[PT_R1]
#elif defined(__mips__) #elif defined(__mips__)
▲ Show 20 Lines • Show All 120 Lines • Show Last 20 Lines