Page MenuHomePhabricator

[flang] Correct handling of null pointer initializers
ClosedPublic

Authored by klausler on Nov 17 2020, 1:22 PM.

Details

Summary

Fortran defines "null-init" null pointer initializers as
being function references, syntactically, that have to resolve
to calls to the intrinsic function NULL() with no actual
arguments.

Diff Detail

Event Timeline

klausler created this revision.Nov 17 2020, 1:22 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 17 2020, 1:22 PM
klausler requested review of this revision.Nov 17 2020, 1:22 PM
PeteSteinfeld accepted this revision.Nov 17 2020, 8:35 PM

Aside from the noted items, all builds, tests, and looks good.

flang/lib/Semantics/resolve-names.cpp
5737

Something weird is going on with this file. When I look at this file in my downloaded version, this line that begins with "if (auto" is at line 5733 rather than line 5737 as this display shows.

It looks to me like your version of the file doesn't contain the changes from D91560. Please be sure to integrate those changes before merging.

5744–5746

It would be good to have a test for this.

5758–5759

It would be good to have a test for this.

This revision is now accepted and ready to land.Nov 17 2020, 8:35 PM
This revision was automatically updated to reflect the committed changes.