[lldb] Fix a couple of remote llgs tests

[DavidSpickett]

Summary

init_llgs_test no longer takes an argument
but these two were not updated.

Also fix some mistakes in TestAutoInstallMainExecutable
to get it passing again.

[DavidSpickett]

I presume these tests aren't commonly run or have been masked by the expected failures.

[DavidSpickett]

For reference the argument was removed in: https://reviews.llvm.org/D90313

[labath]

In D91612#2399408, @DavidSpickett wrote:

I presume these tests aren't commonly run or have been masked by the expected failures.

Yes, that seems to be the case, though I don't actually see a reason for that.

This is definitely the right fix, though it seems that we have a bigger problem in that one of the decorators is misbehaving and causing the tests not to run.

My money is on @skipIf(remote=False)

lldb/test/API/commands/target/auto-install-main-executable/TestAutoInstallMainExecutable.py

class TestAutoInstallMainExecutable(gdbremote_testcase.GdbRemoteTestCaseBase):
     mydir = TestBase.compute_mydir(__file__)
 
     @llgs_test
     @no_debug_info_test
     @skipIf(remote=False)
     @expectedFailureAll(hostoslist=["windows"], triple='.*-android')
     def test_target_auto_install_main_executable(self):
         self.build()
-        self.init_llgs_test(False)
+        self.init_llgs_test()
 
         # Manually install the modified binary.
         working_dir = lldb.remote_platform.GetWorkingDirectory()
         src_device = lldb.SBFileSpec(self.getBuildArtifact("a.device.out"))
         dest = lldb.SBFileSpec(os.path.join(working_dir, "a.out"))
         err = lldb.remote_platform.Put(src_device, dest)
         if err.Fail():
             raise RuntimeError(
def test_target_auto_install_main_executable(self):
         self.runCmd("platform select %s"%configuration.lldb_platform_name)
         self.runCmd("platform connect %s" % (connect_url))
 
         # Create the target with the original file.
         self.runCmd("target create --remote-file %s %s "%
                                         (os.path.join(working_dir,dest.GetFilename()),
                                             self.getBuildArtifact("a.out")))
 
-        target = new_debugger.GetSelectedTarget()
+        target = self.dbg.GetSelectedTarget()
         breakpoint = target.BreakpointCreateByName("main")
 
-        launch_info = taget.GetLaunchInfo()
+        launch_info = target.GetLaunchInfo()
         error = lldb.SBError()
         process = target.Launch(launch_info, error)
         self.assertTrue(process, PROCESS_IS_VALID)
 
         thread = lldbutil.get_stopped_thread(process, lldb.eStopReasonBreakpoint)
         self.assertTrue(
             thread.IsValid(),
             "There should be a thread stopped due to breakpoint")
 
         frame = thread.GetFrameAtIndex(0)
         self.assertEqual(frame.GetFunction().GetName(), "main")
 
         self.expect("target variable build", substrs=['"device"'],
                 msg="Magic in the binary is wrong")
 
         process.Continue()

lldb/test/API/tools/lldb-server/platform-process-connect/TestPlatformProcessConnect.py

class TestPlatformProcessConnect(gdbremote_testcase.GdbRemoteTestCaseBase):
     mydir = TestBase.compute_mydir(__file__)
 
     @llgs_test
     @no_debug_info_test
     @skipIf(remote=False)
     @expectedFailureAll(hostoslist=["windows"], triple='.*-android')
     def test_platform_process_connect(self):
         self.build()
-        self.init_llgs_test(False)
+        self.init_llgs_test()
 
         working_dir = lldb.remote_platform.GetWorkingDirectory()
         src = lldb.SBFileSpec(self.getBuildArtifact("a.out"))
         dest = lldb.SBFileSpec(os.path.join(working_dir, "a.out"))
         err = lldb.remote_platform.Put(src, dest)
         if err.Fail():
             raise RuntimeError(
                 "Unable copy '%s' to '%s'.\n>>> %s" %