[sanitizers][test] Test sanitizer_common and ubsan_minimal on Solaris

[ro]

Summary

During the initial Solaris sanitizer port, I missed to enable the sanitizer_common and ubsan_minimal testsuites. This patch fixes this, correcting a few unportabilities:

• Posix/getpass.cpp failed to link since Solaris lacks libutil. Omitting the library lets the test PASS, but I thought adding %libutil along the lines of %librt to be overkill.
• One subtest of Posix/getpw_getgr.cpp is disabled because Solaris getpwent_r has a different signature than expected.
• /dev/null is a symlink on Solaris.
• XPG7 specifies that uname returns a non-negative value on success.

Tested on amd64-pc-solaris2.11 and sparcv9-sun-solaris2.11.

[vitalybuka]

compiler-rt/test/sanitizer_common/CMakeLists.txt

65–70

compiler-rt/test/sanitizer_common/TestCases/Posix/getpass.cpp

6

XFAIL or UNSUPPORTED?
I assume that XFAIL is useful when thing is consistently broken and it should be fixed in future.
If you don't expect -lutil supported it should be probably UNSUPPORTED

[ro]

compiler-rt/test/sanitizer_common/CMakeLists.txt

65–70

Unless I'm mistaken, that would disable the SanitizerCommon-ubsan-x86_64-SunOS tests which do work just fine, just like the code above (l.65-67) only disables the ASan tests on sparc*.

compiler-rt/test/sanitizer_common/TestCases/Posix/getpass.cpp

6

You're right: looking at the contents of libutil on Linux I see that most (all) of those functions live in libc on Solaris. I hadn't even heard about libutil ever before, so I'm pretty certain this won't be introduced.

I'll make it UNSUPPORTED, unless I get around to implementing %libutil.

[ro]

compiler-rt/test/sanitizer_common/CMakeLists.txt

65–70

Unless I'm mistaken, that would disable the SanitizerCommon-ubsan-x86_64-SunOS tests which do work just fine, just like the code above (l.65-67) only disables the ASan tests on sparc*.

I've tried this now and indeed with your suggested change the SanitizerCommon-ubsan-x86_64-SunOS tests change from PASS to UNSUPPORTED. So I'm going to leave this as is.

[ro]

getpass.cpp changed to UNSUPPORTED.

compiler-rt/lib/sanitizer_common/sanitizer_platform_interceptors.h

 #define SANITIZER_INTERCEPT_PTHREAD_SETCANCEL SI_POSIX
 #define SANITIZER_INTERCEPT_MINCORE (SI_LINUX || SI_NETBSD || SI_SOLARIS)
 #define SANITIZER_INTERCEPT_PROCESS_VM_READV SI_LINUX
 #define SANITIZER_INTERCEPT_CTERMID \
   (SI_LINUX || SI_MAC || SI_FREEBSD || SI_NETBSD || SI_SOLARIS)
 #define SANITIZER_INTERCEPT_CTERMID_R (SI_MAC || SI_FREEBSD || SI_SOLARIS)
 
 #define SANITIZER_INTERCEPTOR_HOOKS \
-  (SI_LINUX || SI_MAC || SI_WINDOWS || SI_NETBSD)
+  (SI_LINUX || SI_MAC || SI_WINDOWS || SI_NETBSD || SI_SOLARIS)
 #define SANITIZER_INTERCEPT_RECV_RECVFROM SI_POSIX
 #define SANITIZER_INTERCEPT_SEND_SENDTO SI_POSIX
 #define SANITIZER_INTERCEPT_EVENTFD_READ_WRITE SI_LINUX
 
 #define SANITIZER_INTERCEPT_STAT \
   (SI_FREEBSD || SI_MAC || SI_ANDROID || SI_NETBSD || SI_SOLARIS)
 #define SANITIZER_INTERCEPT_LSTAT (SI_NETBSD || SI_FREEBSD)
 #define SANITIZER_INTERCEPT___XSTAT (!SANITIZER_INTERCEPT_STAT && SI_POSIX)

compiler-rt/test/sanitizer_common/CMakeLists.txt

foreach(tool ${SUPPORTED_TOOLS})
   string(TOUPPER ${tool} tool_toupper)
   if(${tool_toupper}_SUPPORTED_ARCH AND NOT COMPILER_RT_STANDALONE_BUILD)
     list(APPEND SANITIZER_COMMON_TEST_DEPS ${tool})
   endif()
   set(TEST_ARCH ${${tool_toupper}_SUPPORTED_ARCH})
   if(APPLE)
     darwin_filter_host_archs(${tool_toupper}_SUPPORTED_ARCH TEST_ARCH)
   endif()
   if(${tool} STREQUAL "asan")
     list(REMOVE_ITEM TEST_ARCH sparc sparcv9)
   endif()
+  if(OS_NAME MATCHES "SunOS" AND ${tool} STREQUAL "asan")
+    list(REMOVE_ITEM TEST_ARCH x86_64)
+  endif()
 
   # TODO(dliew): We should iterate over the different
   # Apple platforms, not just macOS.
   foreach(arch ${TEST_ARCH})
     set(SANITIZER_COMMON_LIT_TEST_MODE ${tool})
     set(SANITIZER_COMMON_TEST_TARGET_ARCH ${arch})
     get_test_cc_for_arch(${arch} SANITIZER_COMMON_TEST_TARGET_CC SANITIZER_COMMON_TEST_TARGET_CFLAGS)
     set(CONFIG_NAME ${tool}-${arch}-${OS_NAME})

compiler-rt/test/sanitizer_common/TestCases/Posix/fgetln.cpp

 // RUN: %clangxx -O0 -g %s -o %t && %run %t
 // UNSUPPORTED: linux
+// fgetln is BSD-only.
+// UNSUPPORTED: solaris
 
 #include <assert.h>
 #include <stdio.h>
 #include <stdlib.h>
 
 int main(void) {
   FILE *fp = fopen("/etc/hosts", "r");
   assert(fp);

compiler-rt/test/sanitizer_common/TestCases/Posix/getpass.cpp

 // RUN: %clangxx -O0 -g %s -lutil -o %t && %run %t | FileCheck %s
 
 // REQUIRES: stable-runtime
 // XFAIL: android && asan
+// No libutil.
+// XFAIL: solaris
 
 #include <assert.h>
 #include <stdio.h>
 #include <string.h>
 #if __linux__
 #include <pty.h>
 #elif defined(__FreeBSD__)
 #include <libutil.h>
 #include <pwd.h>
 #include <sys/ioctl.h>
 #include <sys/termios.h>
 #include <sys/types.h>
+#elif defined(__sun__) && defined(__svr4__)
+#include <termios.h>
 #else
 #include <util.h>
 #endif
 #include <unistd.h>
 
 int
 main (int argc, char** argv)
 {

compiler-rt/test/sanitizer_common/TestCases/Posix/getpw_getgr.cpp

int main(int argc, const char *argv[]) {
   test<group>(&getgrnam, any_group.get());
 
 #if !defined(__ANDROID__)
   setpwent();
   test<passwd>(&getpwent);
   setgrent();
   test<group>(&getgrent);
 
-#if !defined(__APPLE__)
+#if !defined(__APPLE__) && !(defined(__sun__) && defined(__svr4__))
   setpwent();
   test_r<passwd>(&getpwent_r);
   setgrent();
   test_r<group>(&getgrent_r);
 #endif
 
   test_r<passwd>(&getpwuid_r, 0);
   test_r<passwd>(&getpwnam_r, "root");

compiler-rt/test/sanitizer_common/TestCases/Posix/lstat.cpp

 // RUN: %clangxx -O0 -g %s -o %t && %run %t
 
 #include <assert.h>
 #include <stdlib.h>
 #include <sys/stat.h>
 
 int main(void) {
   struct stat st;
 
   assert(!lstat("/dev/null", &st));
+#if defined(__sun__) && defined(__svr4__)
+  assert(S_ISLNK(st.st_mode));
+#else
   assert(S_ISCHR(st.st_mode));
+#endif
 
   return 0;
 }

compiler-rt/test/sanitizer_common/TestCases/Posix/uname.c

 // RUN: %clang %s -o %t && %run %t
 
 #include <assert.h>
 #include <stdio.h>
 #include <sys/utsname.h>
 
 int main() {
   struct utsname buf;
   int err = uname(&buf);
-  assert(err == 0);
+  assert(err >= 0);
   printf("%s %s %s %s %s\n", buf.sysname, buf.nodename, buf.release,
          buf.version, buf.machine);
 }

compiler-rt/test/sanitizer_common/lit.common.cfg.py

 config.substitutions.append( ("%collect_stack_traces", collect_stack_traces) )
 config.substitutions.append( ("%tool_name", config.tool_name) )
 config.substitutions.append( ("%tool_options", tool_options) )
 config.substitutions.append( ('%env_tool_opts=',
                               'env ' + tool_options + '=' + default_tool_options_str))
 
 config.suffixes = ['.c', '.cpp']
 
-if config.host_os not in ['Linux', 'Darwin', 'NetBSD', 'FreeBSD']:
+if config.host_os not in ['Linux', 'Darwin', 'NetBSD', 'FreeBSD', 'SunOS']:
   config.unsupported = True
 
 if not config.parallelism_group:
   config.parallelism_group = 'shadow-memory'
 
 if config.host_os == 'NetBSD':
   config.substitutions.insert(0, ('%run', config.netbsd_noaslr_prefix))

compiler-rt/test/ubsan_minimal/lit.common.cfg.py

 # Define %clang and %clangxx substitutions to use in test RUN lines.
 config.substitutions.append( ("%clang ", build_invocation(clang_ubsan_cflags)) )
 config.substitutions.append( ("%clangxx ", build_invocation(clang_ubsan_cxxflags)) )
 
 # Default test suffixes.
 config.suffixes = ['.c', '.cpp']
 
 # Check that the host supports UndefinedBehaviorSanitizerMinimal tests
-if config.host_os not in ['Linux', 'FreeBSD', 'NetBSD', 'Darwin', 'OpenBSD']: # TODO: Windows
+if config.host_os not in ['Linux', 'FreeBSD', 'NetBSD', 'Darwin', 'OpenBSD', 'SunOS']: # TODO: Windows
   config.unsupported = True
 
 # Don't target x86_64h if the test machine can't execute x86_64h binaries.
 if '-arch x86_64h' in target_cflags and 'x86_64h' not in config.available_features:
   config.unsupported = True
 
 config.available_features.add('arch=' + config.target_arch)