This is an archive of the discontinued LLVM Phabricator instance.

Differential D91600

[llvm] NFC: Cleanup llvm-yaml-numeric-parser-fuzzer
ClosedPublic

Authored by kbobyrev on Nov 17 2020, 1:27 AM.

Details

Reviewers
kadircet
Commits
rGeefd620a2572: [llvm] NFC: Cleanup llvm-yaml-numeric-parser-fuzzer
Summary
  • Use static variables instead of non-trivially destructible global ones.
  • Remove unused header.

Diff Detail

Unit TestsFailed

TimeTest
420 mslinux > HWAddressSanitizer-x86_64.TestCases::sizes.cpp
50 mslinux > SanitizerCommon-Unit._/Sanitizer-x86_64-Test::SanitizerCommon.StackDepotPrint

Event Timeline

kbobyrev created this revision.Nov 17 2020, 1:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 17 2020, 1:27 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
kbobyrev requested review of this revision.Nov 17 2020, 1:27 AM
Harbormaster completed remote builds in B79067: Diff 305696.Nov 17 2020, 2:12 AM
kbobyrev retitled this revision from [llvm] Cleanup llvm-yaml-numeric-parser-fuzzer to [llvm] NFC: Cleanup llvm-yaml-numeric-parser-fuzzer.Nov 19 2020, 2:51 AM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 15 2021, 5:53 AM
This revision was landed with ongoing or failed builds.
Closed by commit rGeefd620a2572: [llvm] NFC: Cleanup llvm-yaml-numeric-parser-fuzzer (authored by kbobyrev). · Explain Why
This revision was automatically updated to reflect the committed changes.
kbobyrev added a commit: rGeefd620a2572: [llvm] NFC: Cleanup llvm-yaml-numeric-parser-fuzzer.

Revision Contents

PathSize
llvm/
tools/
llvm-yaml-numeric-parser-fuzzer/
11 lines

Diff 305696

llvm/tools/llvm-yaml-numeric-parser-fuzzer/yaml-numeric-parser-fuzzer.cpp

//===-- yaml-numeric-parser-fuzzer.cpp - Fuzzer for YAML numeric parser ---===// //===-- yaml-numeric-parser-fuzzer.cpp - Fuzzer for YAML numeric parser ---===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#include "llvm/ADT/StringRef.h" #include "llvm/ADT/StringRef.h"
#include "llvm/Support/Regex.h" #include "llvm/Support/Regex.h"
#include "llvm/Support/YAMLTraits.h" #include "llvm/Support/YAMLTraits.h"
#include <cassert>
#include <string> #include <string>
llvm::Regex Infinity("^[-+]?(\\.inf|\\.Inf|\\.INF)$");
llvm::Regex Base8("^0o[0-7]+$");
llvm::Regex Base16("^0x[0-9a-fA-F]+$");
llvm::Regex Float("^[-+]?(\\.[0-9]+|[0-9]+(\\.[0-9]*)?)([eE][-+]?[0-9]+)?$");
inline bool isNumericRegex(llvm::StringRef S) { inline bool isNumericRegex(llvm::StringRef S) {
static llvm::Regex Infinity("^[-+]?(\\.inf|\\.Inf|\\.INF)$");
static llvm::Regex Base8("^0o[0-7]+$");
static llvm::Regex Base16("^0x[0-9a-fA-F]+$");
static llvm::Regex Float(
"^[-+]?(\\.[0-9]+|[0-9]+(\\.[0-9]*)?)([eE][-+]?[0-9]+)?$");
if (S.equals(".nan") || S.equals(".NaN") || S.equals(".NAN")) if (S.equals(".nan") || S.equals(".NaN") || S.equals(".NAN"))
return true; return true;
if (Infinity.match(S)) if (Infinity.match(S))
return true; return true;
if (Base8.match(S)) if (Base8.match(S))
Show All 18 Lines