Mark trivial_abi unique_ptr tests as unsupported in clang-11.

[zoecarver]

Summary

It would appear that these tests fail for clang-11. See the CI and Compiler Explorer. This was exposed while testing D66262.

[Mordante]

libcxx/test/libcxx/memory/trivial_abi/unique_ptr_arg.pass.cpp

15

Can you update this comment in all modified tests?

[ldionne]

It seems to me like the most likely issue is just that D66262 breaks these tests -- is that possible?

[ldionne]

In D91586#2400803, @ldionne wrote:

It seems to me like the most likely issue is just that D66262 breaks these tests -- is that possible?

Because our CI is using Clang 11.0.1, and it hasn't been failing because of this so far AFAICT.

[zoecarver]

It seems to me like the most likely issue is just that D66262 breaks these tests -- is that possible?

That's what I originally thought (because that's the only patch causing CI failures). But check out the Godbolt link in the description, it also fails there which makes me think maybe it's unrelated.

[ldionne]

Is it possible that the difference lies between 11.0.0 (your godbolt link) and 11.0.1 (the CI)?

[zoecarver]

Is it possible that the difference lies between 11.0.0 (your godbolt link) and 11.0.1 (the CI)?

Godbolt also fails on trunk, it would be odd (but not impossible) for it to be fixed only for 11.0.1 and then broken again for trunk. Also, that patch that's failing is a super small change, it seems very unlikely that it is responsible for the failures.

[ldionne]

In D91586#2400879, @zoecarver wrote:

Is it possible that the difference lies between 11.0.0 (your godbolt link) and 11.0.1 (the CI)?

Godbolt also fails on trunk, it would be odd (but not impossible) for it to be fixed only for 11.0.1 and then broken again for trunk. Also, that patch that's failing is a super small change, it seems very unlikely that it is responsible for the failures.

It doesn't fail on trunk when you actually use libc++! https://godbolt.org/z/af66T1

Clang on Godbolt uses libstdc++ by default (probably because it runs on some Unix).

[zoecarver]

In D91586#2400886, @ldionne wrote:

In D91586#2400879, @zoecarver wrote:

Is it possible that the difference lies between 11.0.0 (your godbolt link) and 11.0.1 (the CI)?

Godbolt also fails on trunk, it would be odd (but not impossible) for it to be fixed only for 11.0.1 and then broken again for trunk. Also, that patch that's failing is a super small change, it seems very unlikely that it is responsible for the failures.

It doesn't fail on trunk when you actually use libc++! https://godbolt.org/z/af66T1

Clang on Godbolt uses libstdc++ by default (probably because it runs on some Unix).

Ah, you're right! I always forget. So it might be resolved in 11.0.1. I'll pull down the Docker image and do a full investigation :)

libcxx/test/libcxx/memory/trivial_abi/unique_ptr_arg.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // <memory>
 
 // Test unique_ptr<T> with trivial_abi as parameter type.
 
 // ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_ABI_ENABLE_UNIQUE_PTR_TRIVIAL_ABI
 
 // There were assertion failures in both parse and codegen, which are fixed in clang 11.
-// UNSUPPORTED: gcc, clang-4, clang-5, clang-6, clang-7, clang-8, clang-9, clang-10
+// UNSUPPORTED: gcc, clang-4, clang-5, clang-6, clang-7, clang-8, clang-9, clang-10, clang-11
 
 #include <memory>
 #include <cassert>
 
 __attribute__((noinline)) void call_something() { asm volatile(""); }
 
 struct Node {
   int* shared_val;

libcxx/test/libcxx/memory/trivial_abi/unique_ptr_array.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // <memory>
 
 // Test unique_ptr<T[]> with trivial_abi as parameter type.
 
 // ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_ABI_ENABLE_UNIQUE_PTR_TRIVIAL_ABI
 
 // There were assertion failures in both parse and codegen, which are fixed in clang 11.
-// UNSUPPORTED: gcc, clang-4, clang-5, clang-6, clang-7, clang-8, clang-9, clang-10
+// UNSUPPORTED: gcc, clang-4, clang-5, clang-6, clang-7, clang-8, clang-9, clang-10, clang-11
 // UNSUPPORTED: c++03
 
 #include <memory>
 #include <cassert>
 
 __attribute__((noinline)) void call_something() { asm volatile(""); }
 
 struct Node {

libcxx/test/libcxx/memory/trivial_abi/unique_ptr_destruction_order.pass.cpp

 
 // Test arguments destruction order involving unique_ptr<T> with trivial_abi.
 // Note: Unlike other tests in this directory, this is the only test that
 // exhibits a difference between the two modes in Microsft ABI.
 
 // ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_ABI_ENABLE_UNIQUE_PTR_TRIVIAL_ABI
 
 // There were assertion failures in both parse and codegen, which are fixed in clang 11.
-// UNSUPPORTED: gcc, clang-4, clang-5, clang-6, clang-7, clang-8, clang-9, clang-10
+// UNSUPPORTED: gcc, clang-4, clang-5, clang-6, clang-7, clang-8, clang-9, clang-10, clang-11
 
 #include <memory>
 #include <cassert>
 
 __attribute__((noinline)) void call_something() { asm volatile(""); }
 
 struct Base {
   char* shared_buff;

libcxx/test/libcxx/memory/trivial_abi/unique_ptr_ret.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // <memory>
 
 // Test unique_ptr<T> with trivial_abi as return-type.
 
 // ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_ABI_ENABLE_UNIQUE_PTR_TRIVIAL_ABI
 
 // There were assertion failures in both parse and codegen, which are fixed in clang 11.
-// UNSUPPORTED: gcc, clang-4, clang-5, clang-6, clang-7, clang-8, clang-9, clang-10
+// UNSUPPORTED: gcc, clang-4, clang-5, clang-6, clang-7, clang-8, clang-9, clang-10, clang-11
 
 #include <memory>
 #include <cassert>
 
 __attribute__((noinline)) void call_something() { asm volatile(""); }
 
 struct Node {
   explicit Node() {}