Page MenuHomePhabricator

[coro] Async coroutines: Make sure we can handle control flow in suspend point dispatch function
ClosedPublic

Authored by aschwaighofer on Nov 16 2020, 8:16 AM.

Details

Summary

Create a valid basic block with a terminator before we call
InlineFunction.

Diff Detail

Unit TestsFailed

TimeTest
400 mslinux > HWAddressSanitizer-x86_64.TestCases::sizes.cpp
Script: -- : 'RUN: at line 3'; /mnt/disks/ssd0/agent/llvm-project/build/./bin/clang --driver-mode=g++ -m64 -gline-tables-only -fsanitize=hwaddress -fuse-ld=lld -mcmodel=large -mllvm -hwasan-globals -mllvm -hwasan-use-short-granules -mllvm -hwasan-instrument-landing-pads=0 -mllvm -hwasan-instrument-personality-functions /mnt/disks/ssd0/agent/llvm-project/compiler-rt/test/hwasan/TestCases/sizes.cpp -nostdlib++ -lstdc++ -o /mnt/disks/ssd0/agent/llvm-project/build/projects/compiler-rt/test/hwasan/X86_64/TestCases/Output/sizes.cpp.tmp

Event Timeline

aschwaighofer created this revision.Nov 16 2020, 8:16 AM
aschwaighofer requested review of this revision.Nov 16 2020, 8:16 AM
eeckstein accepted this revision.Nov 16 2020, 8:18 AM
eeckstein added a subscriber: eeckstein.

LGTM!

This revision is now accepted and ready to land.Nov 16 2020, 8:18 AM
This revision was landed with ongoing or failed builds.Nov 16 2020, 12:00 PM
This revision was automatically updated to reflect the committed changes.