Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D91547

[coro] Async coroutines: Make sure we can handle control flow in suspend point dispatch function
ClosedPublic
Actions

Authored by aschwaighofer on Nov 16 2020, 8:16 AM.

Details

Reviewers

rjmccall
eeckstein

Commits

rGd861cc0e4311: [coro] Async coroutines: Make sure we can handle control flow in suspend point…

Summary

Create a valid basic block with a terminator before we call
InlineFunction.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

aschwaighofer created this revision.Nov 16 2020, 8:16 AM

Herald added a project: Restricted Project. · View Herald TranscriptNov 16 2020, 8:16 AM

Herald added subscribers: llvm-commits, lxfind, modocache, hiraditya. · View Herald Transcript

aschwaighofer requested review of this revision.Nov 16 2020, 8:16 AM

LGTM!

This revision is now accepted and ready to land.Nov 16 2020, 8:18 AM

Harbormaster completed remote builds in B78969: Diff 305523.Nov 16 2020, 9:23 AM

This revision was landed with ongoing or failed builds.Nov 16 2020, 12:00 PM

Closed by commit rGd861cc0e4311: [coro] Async coroutines: Make sure we can handle control flow in suspend point… (authored by aschwaighofer). · Explain Why

This revision was automatically updated to reflect the committed changes.

aschwaighofer added a commit: rGd861cc0e4311: [coro] Async coroutines: Make sure we can handle control flow in suspend point….

Revision Contents
Changeset List

Path

Size

llvm/

lib/

Transforms/

Coroutines/

2 lines

test/

Transforms/

Coroutines/

54 lines

Diff 305571

llvm/lib/Transforms/Coroutines/CoroSplit.cpp

Loading...

llvm/test/Transforms/Coroutines/coro-async.ll

Loading...